Skip to content
This repository was archived by the owner on Sep 8, 2021. It is now read-only.

Commit ef53022

Browse files
committed
fix: prevent netlify dev from attempting to recursively call itself
The CLI detects different framework commands in package.json, and will throw if it detects `netlify dev` in the default script while running `netlify dev` in order to avoid recursively calling itself. By removing the `netlify dev` from the `start` and `dev` scripts and adjusting the CLI logic to recognize `netlify dev:exec` as distinct from `netlify:dev`, we can get this project working as expected. Also updates package.json dependencies. see also: #26 netlify/cli#1798
1 parent 159b95d commit ef53022

File tree

5 files changed

+22700
-7703
lines changed

5 files changed

+22700
-7703
lines changed

.gitignore

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# See https://help.github.com/ignore-files/ for more about ignoring files.
22

3+
# .env
4+
.env
5+
6+
# eslint cache
7+
.eslintcache
8+
39
# dependencies
410
/node_modules
511

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,10 @@ Click the [Deploy to Netlify Button](https://app.netlify.com/start/deploy?reposi
9696
npm run bootstrap
9797
```
9898

99-
10. Run project locally
99+
10. Start developing!
100100

101101
```bash
102-
npm start
102+
netlify dev
103103
```
104104

105105
## TLDR; Quick Deploy

netlify.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@
66
publish = "build"
77

88
[dev]
9-
# Local dev command. A.k.a npm start
10-
command = "react-scripts start"
9+
# Call react-scripts start
10+
command = "npm start"

0 commit comments

Comments
 (0)