From dd005a67515ad72d54a25a9d1da6cbf6aaa86a61 Mon Sep 17 00:00:00 2001 From: Raees Date: Mon, 1 Jul 2019 20:27:56 +0500 Subject: [PATCH 1/2] Make ports for local server dynamic --- src/commands/dev/index.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/commands/dev/index.js b/src/commands/dev/index.js index 3ebc80d..e50b662 100644 --- a/src/commands/dev/index.js +++ b/src/commands/dev/index.js @@ -212,11 +212,19 @@ class DevCommand extends Command { settings = { noCmd: true, port: 8888, - proxyPort: 3999, + proxyPort: await getPort({ port: 3999 }), dist }; } + // Reset port if not manually specified, to make it dynamic + if (!(config.dev && config.dev.port)) { + settings = { + port: await getPort({ port: settings.port }), + ...settings + }; + } + startDevServer(settings, this.log); // serve functions from zip-it-and-ship-it From 1320b22328af2e91f55b51960a4747fb56dfe604 Mon Sep 17 00:00:00 2001 From: Raees Date: Mon, 8 Jul 2019 20:22:01 +0500 Subject: [PATCH 2/2] Check for port flag --- src/commands/dev/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/commands/dev/index.js b/src/commands/dev/index.js index e50b662..8578c77 100644 --- a/src/commands/dev/index.js +++ b/src/commands/dev/index.js @@ -218,7 +218,7 @@ class DevCommand extends Command { } // Reset port if not manually specified, to make it dynamic - if (!(config.dev && config.dev.port)) { + if (!(config.dev && config.dev.port) && !flags.port) { settings = { port: await getPort({ port: settings.port }), ...settings