Skip to content
This repository was archived by the owner on Sep 12, 2019. It is now read-only.

Commit f68215c

Browse files
author
sw-yx
committed
minor fixes
1 parent 70ebded commit f68215c

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

README.md

+7-7
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ Netlify Dev will attempt to detect the SSG or build command that you are using,
8484
**Overriding the detectors**: The number of [project types which Netlify Dev can detect](https://github.com/netlify/netlify-dev-plugin/tree/master/src/detectors) is growing, but if yours is not yet supported (contributions welcome!), you can instruct Netlify Dev to run the project on your behalf by declaring it in a `[dev]` block of your `netlify.toml` file.
8585
8686
```toml
87-
#sample dev block in the toml
87+
# sample dev block in the toml
88+
# note: each of these fields are OPTIONAL and should only be used if you need an override
8889
[dev]
8990
command = "yarn start" # Command to start your dev server
9091
port = 3000 # Port that the dev server will be listening on
@@ -226,16 +227,15 @@ After you have installed an add-on, it will be visible with the `netlify addons:
226227
227228
For now, it is important to include instructions to create addons for each member of your team, as there is no way to specify addons inside of `netlify.toml`. We are working on this.
228229
229-
230230
## Contributing/Local Development
231231
232232
Thanks for contributing! You'll need to follow these steps to run Netlify CLI and `netlify-dev-plugin` locally:
233233

234234
0. uninstall any globally installed versions of `netlify-cli`
235-
1. clone and install deps for https://github.com/netlify/cli
236-
2. `npm link` from inside the `cli` folder
237-
3. clone and install deps for this repo
238-
4. inside the `netlify-dev-plugin` folder, run `yarn link`
239-
5. inside the `cli` folder, run `yarn link "netlify-dev-plugin"`
235+
1. clone and install deps for https://github.com/netlify/cli
236+
1. `npm link` from inside the `cli` folder
237+
1. clone and install deps for this repo
238+
1. inside the `netlify-dev-plugin` folder, run `yarn link`
239+
1. inside the `cli` folder, run `yarn link "netlify-dev-plugin"`
240240

241241
Now you're both ready to start testing `netlify dev` and to contribute to the project! Note these are untested instructions, please get in touch if you're unable to follow them clearly and we'll work with you. Or ping [@swyx](https://twitter.com/swyx).

src/detectors/cra.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,6 @@ module.exports = function() {
3434
env: { ...process.env, BROWSER: "none", PORT: 3000 },
3535
possibleArgsArrs,
3636
urlRegexp: new RegExp(`(http://)([^:]+:)${3000}(/)?`, "g"),
37-
dist: "dist"
37+
dist: "public"
3838
};
3939
};

src/functions-templates/js/token-hider/token-hider.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
const axios = require("axios");
22
const qs = require("qs");
33

4-
export function handler(event, context, callback) {
4+
exports.handler = function(event, context, callback) {
55
// apply our function to the queryStringParameters and assign it to a variable
66
const API_PARAMS = qs.stringify(event.queryStringParameters);
77
// Get env var values defined in our Netlify site UI
@@ -36,4 +36,4 @@ export function handler(event, context, callback) {
3636
if (event.httpMethod == "GET") {
3737
get();
3838
}
39-
}
39+
};

0 commit comments

Comments
 (0)