Skip to content

Commit 3c036fc

Browse files
committed
feat: add details to error message
1 parent e989d06 commit 3c036fc

File tree

3 files changed

+11
-13
lines changed

3 files changed

+11
-13
lines changed

src/main.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ describe('get', () => {
135135
})
136136

137137
expect(async () => await blobs.get(key)).rejects.toThrowError(
138-
`Netlify Blobs has generated an internal error: 401 response (ID: ${mockRequestID})`,
138+
`Netlify Blobs has generated an internal error (401 status code, ID: ${mockRequestID})`,
139139
)
140140
expect(mockStore.fulfilled).toBeTruthy()
141141
})
@@ -161,7 +161,7 @@ describe('get', () => {
161161
})
162162

163163
await expect(async () => await blobs.get(key)).rejects.toThrowError(
164-
`Netlify Blobs has generated an internal error: 401 response`,
164+
`Netlify Blobs has generated an internal error (401 status code)`,
165165
)
166166

167167
expect(mockStore.fulfilled).toBeTruthy()
@@ -288,7 +288,7 @@ describe('get', () => {
288288
})
289289

290290
await expect(async () => await blobs.get(key)).rejects.toThrowError(
291-
`Netlify Blobs has generated an internal error: ${errorDetails}`,
291+
`Netlify Blobs has generated an internal error (${errorDetails})`,
292292
)
293293

294294
expect(mockStore.fulfilled).toBeTruthy()
@@ -819,7 +819,7 @@ describe('set', () => {
819819
})
820820

821821
expect(async () => await blobs.set(key, 'value')).rejects.toThrowError(
822-
`Netlify Blobs has generated an internal error: 401 response`,
822+
`Netlify Blobs has generated an internal error (401 status code)`,
823823
)
824824
expect(mockStore.fulfilled).toBeTruthy()
825825
})
@@ -947,7 +947,7 @@ describe('set', () => {
947947
})
948948

949949
await expect(async () => await blobs.set(key, value)).rejects.toThrowError(
950-
`Netlify Blobs has generated an internal error: 401 response`,
950+
`Netlify Blobs has generated an internal error (401 status code)`,
951951
)
952952

953953
expect(mockStore.fulfilled).toBeTruthy()
@@ -1170,7 +1170,7 @@ describe('delete', () => {
11701170
})
11711171

11721172
await expect(async () => await blobs.delete(key)).rejects.toThrowError(
1173-
`Netlify Blobs has generated an internal error: 401 response`,
1173+
`Netlify Blobs has generated an internal error (401 status code)`,
11741174
)
11751175
expect(mockStore.fulfilled).toBeTruthy()
11761176
})
@@ -1236,7 +1236,7 @@ describe('delete', () => {
12361236
})
12371237

12381238
await expect(async () => await blobs.delete(key)).rejects.toThrowError(
1239-
`Netlify Blobs has generated an internal error: 401 response`,
1239+
`Netlify Blobs has generated an internal error (401 status code)`,
12401240
)
12411241

12421242
expect(mockStore.fulfilled).toBeTruthy()

src/server.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ test('If a token is set, rejects any requests with an invalid `authorization` he
196196
})
197197

198198
await expect(async () => await blobs.get('some-key')).rejects.toThrowError(
199-
'Netlify Blobs has generated an internal error: 403 response',
199+
'Netlify Blobs has generated an internal error (403 status code)',
200200
)
201201

202202
await server.stop()

src/util.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,13 @@ import { NF_ERROR, NF_REQUEST_ID } from './headers.ts'
22

33
export class BlobsInternalError extends Error {
44
constructor(res: Response) {
5-
const details = res.headers.get(NF_ERROR) ?? `${res.status} response`
6-
7-
let message = `Netlify Blobs has generated an internal error: ${details}`
5+
let details = res.headers.get(NF_ERROR) || `${res.status} status code`
86

97
if (res.headers.has(NF_REQUEST_ID)) {
10-
message += ` (ID: ${res.headers.get(NF_REQUEST_ID)})`
8+
details += `, ID: ${res.headers.get(NF_REQUEST_ID)}`
119
}
1210

13-
super(message)
11+
super(`Netlify Blobs has generated an internal error (${details})`)
1412

1513
this.name = 'BlobsInternalError'
1614
}

0 commit comments

Comments
 (0)