refactor: Remove unused methods, improve logging.

Author: michael-simons

core/src/main/java/org/neo4j/ogm/context/EntityGraphMapper.java

@@ -117,7 +117,7 @@ public CompileContext map(Object entity, int horizon) {
         // add all the relationships we know about. This includes the relationships that
         // won't be modified by the mapping request.
         for (MappedRelationship mappedRelationship : mappingContext.getRelationships()) {
-            LOGGER.debug("context-init: (${})-[:{}]->(${})", mappedRelationship.getStartNodeId(),
+            LOGGER.debug("context-init: ({})-[:{}]->({})", mappedRelationship.getStartNodeId(),
                 mappedRelationship.getRelationshipType(), mappedRelationship.getEndNodeId());
             compiler.context().registerRelationship(mappedRelationship);
         }
@@ -980,11 +980,9 @@ private void reallyCreateRelationship(CompileContext ctx, Long src, Relationship
         relBuilder.relate(src, tgt);
         LOGGER.debug("context-new: ({})-[{}:{}]->({})", src, relBuilder.reference(), relBuilder.type(), tgt);
 
-        if (relBuilder.isNew()) {  //We only want to create or log new relationships
-            ctx.registerTransientRelationship(new SrcTargetKey(src, tgt),
-                new TransientRelationship(src, relBuilder.reference(), relBuilder.type(), tgt, srcClass,
-                    tgtClass)); // we log the new relationship as part of the transaction context.
-        }
+        ctx.registerTransientRelationship(new SrcTargetKey(src, tgt),
+            new TransientRelationship(src, relBuilder.reference(), relBuilder.type(), tgt, srcClass,
+                tgtClass)); // we log the new relationship as part of the transaction context.
     }
 
     /**

core/src/main/java/org/neo4j/ogm/cypher/compiler/RelationshipBuilder.java

@@ -52,7 +52,6 @@ public interface RelationshipBuilder extends PropertyContainerBuilder<Relationsh
 
     void setRelationshipEntity(boolean relationshipEntity);
 
-    boolean isNew();
     boolean isDirty();
 
     void setDirty(boolean dirty);

core/src/main/java/org/neo4j/ogm/cypher/compiler/builders/node/DefaultRelationshipBuilder.java

@@ -88,11 +88,6 @@ public boolean isSingleton() {
         return singleton;
     }
 
-    @Override
-    public boolean isNew() {
-        return true;
-    }
-
     @Override
     public void setSingleton(boolean b) {
         this.singleton = b;