Skip to content

Commit ecb34a7

Browse files
committed
Better function name
Renamed private function `Transaction#_runDiscardAll()` to `Transaction#_runPullAll()` because it actually executes `PULL_ALL` and not `DISCARD_ALL`.
1 parent fe8d7cf commit ecb34a7

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/v1/transaction.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,11 +165,11 @@ let _states = {
165165
//The transaction is running with no explicit success or failure marked
166166
ACTIVE: {
167167
commit: (connectionHolder, observer) => {
168-
return {result: _runDiscardAll("COMMIT", connectionHolder, observer),
168+
return {result: _runPullAll("COMMIT", connectionHolder, observer),
169169
state: _states.SUCCEEDED}
170170
},
171171
rollback: (connectionHolder, observer) => {
172-
return {result: _runDiscardAll("ROLLBACK", connectionHolder, observer), state: _states.ROLLED_BACK};
172+
return {result: _runPullAll("ROLLBACK", connectionHolder, observer), state: _states.ROLLED_BACK};
173173
},
174174
run: (connectionHolder, observer, statement, parameters) => {
175175
connectionHolder.getConnection().then(conn => {
@@ -250,7 +250,7 @@ let _states = {
250250
}
251251
};
252252

253-
function _runDiscardAll(msg, connectionHolder, observer) {
253+
function _runPullAll(msg, connectionHolder, observer) {
254254
connectionHolder.getConnection().then(
255255
conn => {
256256
observer.resolveConnection(conn);

0 commit comments

Comments
 (0)