extract protocol factory

Author: bigmontz

src/internal/bolt/create.js

@@ -0,0 +1,81 @@
+/**
+ * Copyright (c) 2002-2020 "Neo4j,"
+ * Neo4j Sweden AB [http://neo4j.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { newError } from '../../error'
+import BoltProtocolV1 from '../bolt-protocol-v1'
+import BoltProtocolV2 from '../bolt-protocol-v2'
+import BoltProtocolV3 from '../bolt-protocol-v3'
+import BoltProtocolV4x0 from '../bolt-protocol-v4x0'
+import BoltProtocolV4x1 from '../bolt-protocol-v4x1'
+import BoltProtocolV4x2 from '../bolt-protocol-v4x2'
+import BoltProtocolV4x3 from '../bolt-protocol-v4x3'
+import { Chunker } from '../chunking'
+import Connection from '../connection'
+
+/**
+ * Creates a protocol with a given version
+ *
+ * @param {object} config
+ * @param {number} config.version The version of the protocol
+ * @param {Connection} config.connection The connection used to talk with the database
+ * @param {Chunker} config.chunker The chunker
+ * @param {boolean} config.disableLosslessIntegers Disable the lossless integers
+ * @param {boolean} config.serversideRouting It's using server side routing
+ */
+export default function create ({
+  version,
+  connection, // should be removed
+  chunker,
+  disableLosslessIntegers,
+  serversideRouting
+} = {}) {
+  switch (version) {
+    case 1:
+      return new BoltProtocolV1(connection, chunker, disableLosslessIntegers)
+    case 2:
+      return new BoltProtocolV2(connection, chunker, disableLosslessIntegers)
+    case 3:
+      return new BoltProtocolV3(connection, chunker, disableLosslessIntegers)
+    case 4.0:
+      return new BoltProtocolV4x0(connection, chunker, disableLosslessIntegers)
+    case 4.1:
+      return new BoltProtocolV4x1(
+        connection,
+        chunker,
+        disableLosslessIntegers,
+        serversideRouting
+      )
+    case 4.2:
+      return new BoltProtocolV4x2(
+        connection,
+        chunker,
+        disableLosslessIntegers,
+        serversideRouting
+      )
+    case 4.3:
+      return new BoltProtocolV4x3(
+        connection,
+        chunker,
+        disableLosslessIntegers,
+        serversideRouting
+      )
+    default:
+      throw newError('Unknown Bolt protocol version: ' + version)
+  }
+}

src/internal/bolt/index.js

@@ -1,5 +1,7 @@
 import handshake from './handshake'
+import create from './create'
 
 export default {
-  handshake
+  handshake,
+  create
 }

src/internal/connection-channel.js

@@ -81,19 +81,13 @@ export function createChannelConnection (
         serversideRouting
       )
 
-      // Temporary, this object will not be used in the feature
-      const protocolHandshaker = new ProtocolHandshaker(
+      connection._protocol = Bolt.create({
+        version: protocolVersion,
         connection,
-        channel,
-        connection._chunker,
-        connection._disableLosslessIntegers,
-        connection._log,
-        connection._serversideRouting
-      )
-
-      connection._protocol = protocolHandshaker._createProtocolWithVersion(
-        protocolVersion
-      )
+        chunker: connection._chunker,
+        disableLosslessIntegers: config.disableLosslessIntegers,
+        serversideRouting
+      })
 
       // reset the error handler to just handle errors and forget about the handshake promise
       channel.onerror = connection._handleFatalError.bind(connection)