ConcurrentModificationException in BookmarkManager #1601
Comments
|
Well, I did disable the bookmark manager explicitly and the issue is gone - so in terms of a workaround I'm all good. Adjusted code: public boolean exists(Gav gav) {
Map<String, Object> gavData = objectMapper.convertValue(gav, new TypeReference<>() {});
gavData.computeIfAbsent("classifier", k -> "");
try (var session = session()) {
return session.executeRead(tx -> {
Result res = tx.run(new Query("""
MATCH (root:Artifact)
WHERE
root.groupId = $props.groupId
AND root.artifactId = $props.artifactId
AND root.version = $props.version
AND root.classifier = $props.classifier
RETURN root""",
parameters("props", gavData))
);
return res.hasNext();
});
}
}
private Session session() {
return driver.session(SessionConfig.builder().withBookmarkManager(null).build());
}But still, I think the original concurrency issue should be addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hello team,
I have an issue that
ConcurrentModificationExceptiongets thrown when executing multiple concurrent queries (reads).Neo4j Version: 5.25.1 Community
Neo4j Mode: Single instance
Driver version: Java driver 5.26.3
Operating System: Windows 11 and Debian 12
I'm running these queries in a pooled virtual thread executor limited to 128 threads, heavy load.
TBH I don't even use bookmarks explicitly - this is the code which runs the query:
Stacktrace:
Side note: Unfortunately, the original cause gets stripped down (I couldn't see the exact location where the exception is being thrown) - the stacktrace I pasted here was obtained via debugging.
While this exception frequency differs between my local runs on Windows 11 vs remote Debian 12 it's probably the matter of computation power.
While analyzing the stacktraces the
Neo4jBookmarkManagercode indeed looks faulty (please correct if it's not the case): callingCollections.unmodifiableSet(this.bookmarks)doesn't make the returned collection thread-safe - the underlying collection can still be modified which will be reflected on returned unmodifiable view. I believe that any such changes while iterating over unmodifiable collection (copy constructor) will likely result inConcurrentModificationException.I would really appreciate any kind of workaround (like opting-out of these bookmarks?).
Thanks in advance!
PS probably not necessary but here is the link to the whole codebase: https://github.com/harrel56/jar-hell/blob/97ed256128b9cca7cfaa8db8565ea59bf5d304c9/server/src/main/java/dev/harrel/jarhell/repo/ArtifactRepository.java#L77
The text was updated successfully, but these errors were encountered: