Skip to content

Commit f1a6685

Browse files
committed
Set default value of connection timeout to 5 seconds
It was previously set to 30 seconds which seems too long.
1 parent 3321e09 commit f1a6685

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

driver/src/main/java/org/neo4j/driver/v1/Config.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ public static class ConfigBuilder
187187
private TrustStrategy trustStrategy = trustAllCertificates();
188188
private int routingFailureLimit = 1;
189189
private long routingRetryDelayMillis = TimeUnit.SECONDS.toMillis( 5 );
190-
private int connectionTimeoutMillis = (int) TimeUnit.SECONDS.toMillis( 30 );
190+
private int connectionTimeoutMillis = (int) TimeUnit.SECONDS.toMillis( 5 );
191191

192192
private ConfigBuilder() {}
193193

@@ -386,6 +386,8 @@ public ConfigBuilder withRoutingRetryDelay( long delay, TimeUnit unit )
386386
* <p>
387387
* Timeout value should be greater or equal to zero and represent a valid {@code int} value when converted to
388388
* {@link TimeUnit#MILLISECONDS milliseconds}.
389+
* <p>
390+
* The default value of this parameter is {@code 5 SECONDS}.
389391
*
390392
* @param value the timeout duration
391393
* @param unit the unit in which duration is given

driver/src/test/java/org/neo4j/driver/internal/ConfigTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ public void shouldTurnOnLeakedSessionsLogging()
106106
public void shouldHaveDefaultConnectionTimeout()
107107
{
108108
Config defaultConfig = Config.defaultConfig();
109-
assertEquals( TimeUnit.SECONDS.toMillis( 30 ), defaultConfig.connectionTimeoutMillis() );
109+
assertEquals( TimeUnit.SECONDS.toMillis( 5 ), defaultConfig.connectionTimeoutMillis() );
110110
}
111111

112112
@Test

0 commit comments

Comments
 (0)