Skip to content

Commit e76f8e0

Browse files
committed
Responding to feedback
1 parent 5e1c2c9 commit e76f8e0

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

driver/src/main/java/org/neo4j/driver/internal/NetworkSession.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ public synchronized Transaction beginTransaction( String bookmark )
181181
{
182182
if ( bookmark != null )
183183
{
184-
this.bookmark = bookmark;
184+
setBookmark( bookmark );
185185
}
186186
return beginTransaction();
187187
}
@@ -198,7 +198,7 @@ public <T> T writeTransaction( TransactionWork<T> work )
198198
return transaction( AccessMode.WRITE, work );
199199
}
200200

201-
void setBookmark(String bookmark )
201+
void setBookmark( String bookmark )
202202
{
203203
this.bookmark = bookmark;
204204
}

driver/src/test/java/org/neo4j/driver/internal/NetworkSessionTest.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -602,17 +602,6 @@ public void setLastBookmark()
602602
assertEquals( "TheBookmark", session.lastBookmark() );
603603
}
604604

605-
@Test
606-
public void possibleToOverwriteBookmarkWithNull()
607-
{
608-
NetworkSession session = newSession( mock( ConnectionProvider.class ), WRITE );
609-
session.setBookmark( "TheBookmark" );
610-
611-
session.setBookmark( null );
612-
613-
assertNull( session.lastBookmark() );
614-
}
615-
616605
@Test
617606
public void testPassingNoBookmarkShouldRetainBookmark()
618607
{

0 commit comments

Comments
 (0)