Skip to content

Commit e452350

Browse files
author
Zhen Li
committed
Renamed parse to from to use the same name in other drivers
Removed merge methods as the func is a duplicate of `from`
1 parent 449fc2b commit e452350

File tree

1 file changed

+2
-26
lines changed

1 file changed

+2
-26
lines changed

driver/src/main/java/org/neo4j/driver/Bookmark.java

Lines changed: 2 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
*/
1919
package org.neo4j.driver;
2020

21-
import java.util.Arrays;
2221
import java.util.Set;
2322

2423
import org.neo4j.driver.internal.InternalBookmark;
@@ -38,19 +37,16 @@ public interface Bookmark
3837
{
3938
/**
4039
* Returns a read-only set of bookmark strings that this bookmark instance identifies.
41-
* This method shall only be used to serialize bookmarks.
4240
* @return a read-only set of bookmark strings that this bookmark instance identifies.
4341
*/
4442
Set<String> values();
4543

4644
/**
47-
* Reconstruct bookmark from de-serialized bookmarks string values.
48-
* This method shall not be used to create non-existing bookmarks from random string values.
49-
* To create a bookmark from two and more existing bookmarks, using {@link this#merge(Bookmark...)} and {@link this#merge(Iterable)} instead.
45+
* Reconstruct bookmark from \bookmarks string values.
5046
* @param values values obtained from a previous bookmark.
5147
* @return A bookmark.
5248
*/
53-
static Bookmark parse( Set<String> values )
49+
static Bookmark from( Set<String> values )
5450
{
5551
return InternalBookmark.parse( values );
5652
}
@@ -60,24 +56,4 @@ static Bookmark parse( Set<String> values )
6056
* @return true if the bookmark is empty.
6157
*/
6258
boolean isEmpty();
63-
64-
/**
65-
* Merge more than one bookmarks together into one bookmark.
66-
* @param bookmarks bookmarks to merge
67-
* @return Merged single bookmark.
68-
*/
69-
static Bookmark merge( Bookmark... bookmarks )
70-
{
71-
return merge( Arrays.asList( bookmarks ) );
72-
}
73-
74-
/**
75-
* Merge more than one bookmarks together into one bookmark.
76-
* @param bookmarks bookmarks to merge
77-
* @return Merged singled bookmark.
78-
*/
79-
static Bookmark merge( Iterable<Bookmark> bookmarks )
80-
{
81-
return InternalBookmark.from( bookmarks );
82-
}
8359
}

0 commit comments

Comments
 (0)