Skip to content

Commit e0483f0

Browse files
authored
Turn off UTC tests until server implementation is available (#1262)
1 parent c0a6452 commit e0483f0

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

driver/src/test/java/org/neo4j/driver/integration/TemporalTypesIT.java

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,9 @@
4545
import org.neo4j.driver.Record;
4646
import org.neo4j.driver.Result;
4747
import org.neo4j.driver.Value;
48+
import org.neo4j.driver.internal.util.DisabledOnNeo4jWith;
4849
import org.neo4j.driver.internal.util.EnabledOnNeo4jWith;
50+
import org.neo4j.driver.internal.util.Neo4jFeature;
4951
import org.neo4j.driver.types.IsoDuration;
5052
import org.neo4j.driver.util.ParallelizableIT;
5153
import org.neo4j.driver.util.SessionExtension;
@@ -173,12 +175,14 @@ void shouldSendAndReceiveListsWithRandomLocalDateTimes() {
173175
}
174176

175177
@Test
178+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
176179
void shouldSendDateTimeWithZoneOffset() {
177180
ZoneOffset offset = ZoneOffset.ofHoursMinutes(-4, -15);
178181
testSendValue(ZonedDateTime.of(1845, 3, 25, 19, 15, 45, 22, offset), Value::asZonedDateTime);
179182
}
180183

181184
@Test
185+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
182186
void shouldReceiveDateTimeWithZoneOffset() {
183187
ZoneOffset offset = ZoneOffset.ofHoursMinutes(3, 30);
184188
testReceiveValue(
@@ -188,27 +192,32 @@ void shouldReceiveDateTimeWithZoneOffset() {
188192
}
189193

190194
@Test
195+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
191196
void shouldSendAndReceiveDateTimeWithZoneOffset() {
192197
ZoneOffset offset = ZoneOffset.ofHoursMinutes(-7, -15);
193198
testSendAndReceiveValue(ZonedDateTime.of(2017, 3, 9, 11, 12, 13, 14, offset), Value::asZonedDateTime);
194199
}
195200

196201
@Test
202+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
197203
void shouldSendAndReceiveRandomDateTimeWithZoneOffset() {
198204
testSendAndReceiveRandomValues(TemporalUtil::randomZonedDateTimeWithOffset, Value::asZonedDateTime);
199205
}
200206

201207
@Test
208+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
202209
void shouldSendAndReceiveListsWithRandomDateTimeWithZoneOffsets() {
203210
testSendAndReceiveRandomLists(TemporalUtil::randomZonedDateTimeWithOffset);
204211
}
205212

206213
@Test
214+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
207215
void shouldSendDateTimeRepresentedWithOffsetDateTime() {
208216
testSendValue(OffsetDateTime.of(1851, 9, 29, 1, 29, 42, 987, ZoneOffset.ofHours(-8)), Value::asOffsetDateTime);
209217
}
210218

211219
@Test
220+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
212221
void shouldReceiveDateTimeRepresentedWithOffsetDateTime() {
213222
testReceiveValue(
214223
"RETURN datetime({year:2121, month:1, day:1, hour:2, minute:2, second:2, timezone:'-07:20'})",
@@ -217,29 +226,34 @@ void shouldReceiveDateTimeRepresentedWithOffsetDateTime() {
217226
}
218227

219228
@Test
229+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
220230
void shouldSendAndReceiveDateTimeRepresentedWithOffsetDateTime() {
221231
testSendAndReceiveValue(
222232
OffsetDateTime.of(1998, 12, 12, 23, 54, 14, 123, ZoneOffset.ofHoursMinutes(1, 15)),
223233
Value::asOffsetDateTime);
224234
}
225235

226236
@Test
237+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
227238
void shouldSendAndReceiveRandomDateTimeRepresentedWithOffsetDateTime() {
228239
testSendAndReceiveRandomValues(TemporalUtil::randomOffsetDateTime, Value::asOffsetDateTime);
229240
}
230241

231242
@Test
243+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
232244
void shouldSendAndReceiveListsWithRandomDateTimeRepresentedWithOffsetDateTimes() {
233245
testSendAndReceiveRandomLists(TemporalUtil::randomOffsetDateTime, value -> value.asList(ofOffsetDateTime()));
234246
}
235247

236248
@Test
249+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
237250
void shouldSendDateTimeWithZoneId() {
238251
ZoneId zoneId = ZoneId.of("Europe/Stockholm");
239252
testSendValue(ZonedDateTime.of(2049, 9, 11, 19, 10, 40, 20, zoneId), Value::asZonedDateTime);
240253
}
241254

242255
@Test
256+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
243257
void shouldReceiveDateTimeWithZoneId() {
244258
ZoneId zoneId = ZoneId.of("Europe/London");
245259
testReceiveValue(
@@ -249,17 +263,20 @@ void shouldReceiveDateTimeWithZoneId() {
249263
}
250264

251265
@Test
266+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
252267
void shouldSendAndReceiveDateTimeWithZoneId() {
253268
ZoneId zoneId = ZoneId.of("Europe/Stockholm");
254269
testSendAndReceiveValue(ZonedDateTime.of(2099, 12, 29, 12, 59, 59, 59, zoneId), Value::asZonedDateTime);
255270
}
256271

257272
@Test
273+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
258274
void shouldSendAndReceiveRandomDateTimeWithZoneId() {
259275
testSendAndReceiveRandomValues(TemporalUtil::randomZonedDateTimeWithZoneId, Value::asZonedDateTime);
260276
}
261277

262278
@Test
279+
@DisabledOnNeo4jWith(Neo4jFeature.BOLT_V5)
263280
void shouldSendAndReceiveListsWithRandomDateTimeWithZoneIds() {
264281
testSendAndReceiveRandomLists(TemporalUtil::randomZonedDateTimeWithZoneId);
265282
}

driver/src/test/java/org/neo4j/driver/integration/TransactionBoltV3IT.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import static org.junit.jupiter.api.Assertions.assertTimeoutPreemptively;
2727
import static org.junit.jupiter.api.Assertions.fail;
2828
import static org.neo4j.driver.internal.util.Neo4jFeature.BOLT_V3;
29+
import static org.neo4j.driver.internal.util.Neo4jFeature.BOLT_V5;
2930
import static org.neo4j.driver.util.TestUtil.TX_TIMEOUT_TEST_TIMEOUT;
3031
import static org.neo4j.driver.util.TestUtil.await;
3132

@@ -46,6 +47,7 @@
4647
import org.neo4j.driver.async.ResultCursor;
4748
import org.neo4j.driver.exceptions.ClientException;
4849
import org.neo4j.driver.exceptions.TransientException;
50+
import org.neo4j.driver.internal.util.DisabledOnNeo4jWith;
4951
import org.neo4j.driver.internal.util.EnabledOnNeo4jWith;
5052
import org.neo4j.driver.util.DriverExtension;
5153
import org.neo4j.driver.util.ParallelizableIT;
@@ -83,6 +85,7 @@ void shouldSetTransactionMetadata() {
8385
}
8486

8587
@Test
88+
@DisabledOnNeo4jWith(BOLT_V5)
8689
void shouldSetTransactionMetadataAsync() {
8790
Map<String, Object> metadata = new HashMap<>();
8891
metadata.put("hello", "world");

driver/src/test/java/org/neo4j/driver/internal/util/Neo4jFeature.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ public enum Neo4jFeature {
2525
SPATIAL_TYPES(new Version(3, 4, 0)),
2626
TEMPORAL_TYPES(new Version(3, 4, 0)),
2727
BOLT_V3(new Version(3, 5, 0)),
28-
BOLT_V4(new Version(4, 0, 0));
28+
BOLT_V4(new Version(4, 0, 0)),
29+
BOLT_V5(new Version(5, 0, 0));
2930

3031
private final Version availableFromVersion;
3132

0 commit comments

Comments
 (0)