Revert "Dispatch empty query to server (#1195)" (#1204)

This reverts commit 34035cf.

Author: injectives

driver/src/main/java/org/neo4j/driver/Query.java

@@ -25,10 +25,10 @@
 import org.neo4j.driver.util.Immutable;
 
 import static java.lang.String.format;
-import static org.neo4j.driver.Values.ofValue;
-import static org.neo4j.driver.Values.value;
 import static org.neo4j.driver.internal.util.Iterables.newHashMapWithSize;
 import static org.neo4j.driver.internal.util.Preconditions.checkArgument;
+import static org.neo4j.driver.Values.ofValue;
+import static org.neo4j.driver.Values.value;
 
 /**
  * The components of a Cypher query, containing the query text and parameter map.
@@ -201,6 +201,7 @@ public String toString()
     private static String validateQueryText(String query )
     {
         checkArgument( query != null, "Cypher query text should not be null" );
+        checkArgument( !query.isEmpty(), "Cypher query text should not be an empty string" );
         return query;
     }
 }

driver/src/test/java/org/neo4j/driver/QueryTest.java

@@ -25,7 +25,6 @@
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.junit.MatcherAssert.assertThat;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.neo4j.driver.Values.parameters;
 
@@ -122,12 +121,8 @@ void shouldProhibitNullQuery()
     }
 
     @Test
-    void shouldAcceptEmptyQuery()
+    void shouldProhibitEmptyQuery()
     {
-        // when
-        Query query = new Query( "" );
-
-        // then
-        assertNotNull( query );
+        assertThrows( IllegalArgumentException.class, () -> new Query( "" ) );
     }
 }

driver/src/test/java/org/neo4j/driver/integration/QueryIT.java

@@ -18,9 +18,13 @@
  */
 package org.neo4j.driver.integration;
 
+import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.extension.RegisterExtension;
+import org.junit.jupiter.api.function.Executable;
 
+import java.io.PrintWriter;
+import java.io.StringWriter;
 import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
@@ -30,13 +34,13 @@
 import org.neo4j.driver.Result;
 import org.neo4j.driver.Value;
 import org.neo4j.driver.Values;
-import org.neo4j.driver.exceptions.ClientException;
 import org.neo4j.driver.util.ParallelizableIT;
 import org.neo4j.driver.util.SessionExtension;
 
 import static java.util.Arrays.asList;
 import static org.hamcrest.CoreMatchers.equalTo;
 import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.neo4j.driver.Values.parameters;
 import static org.neo4j.driver.util.TestUtil.assertNoCircularReferences;
@@ -182,7 +186,7 @@ void shouldRunSimpleQuery()
     void shouldFailForIllegalQueries()
     {
         assertThrows( IllegalArgumentException.class, () -> session.run( (String) null ) );
-        assertThrows( ClientException.class, () -> session.run( "" ) );
+        assertThrows( IllegalArgumentException.class, () -> session.run( "" ) );
     }
 
     @Test