Skip to content

Commit d621df4

Browse files
committed
Log driver's hashCode during startup and shutdown
Previously, driver logged its fully qualified class name and hash code when created or closed. Example: ``` Direct driver instance o.n.d.i.InternalDriver@30316b44 created for server address localhost:7687 Closing driver instance o.n.d.i.InternalDriver@30316b44 ``` Class name does not seem to be useful and this commit replaces it with logging of the hash code. Example: ``` Direct driver instance 808545092 created for server address localhost:7687 Closing driver instance 808545092 ```
1 parent f6c4e9b commit d621df4

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@
3838
import org.neo4j.driver.internal.cluster.loadbalancing.LoadBalancingStrategy;
3939
import org.neo4j.driver.internal.cluster.loadbalancing.RoundRobinLoadBalancingStrategy;
4040
import org.neo4j.driver.internal.logging.NettyLogging;
41-
import org.neo4j.driver.internal.metrics.MetricsListener;
4241
import org.neo4j.driver.internal.metrics.InternalAbstractMetrics;
4342
import org.neo4j.driver.internal.metrics.InternalMetrics;
43+
import org.neo4j.driver.internal.metrics.MetricsListener;
4444
import org.neo4j.driver.internal.metrics.spi.Metrics;
4545
import org.neo4j.driver.internal.retry.ExponentialBackoffRetryLogic;
4646
import org.neo4j.driver.internal.retry.RetryLogic;
@@ -160,7 +160,7 @@ protected InternalDriver createDirectDriver( SecurityPlan securityPlan, BoltServ
160160
SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config );
161161
InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config);
162162
Logger log = config.logging().getLog( Driver.class.getSimpleName() );
163-
log.info( "Direct driver instance %s created for server address %s", driver, address.toString() );
163+
log.info( "Direct driver instance %s created for server address %s", driver.hashCode(), address );
164164
return driver;
165165
}
166166

@@ -181,7 +181,7 @@ protected InternalDriver createRoutingDriver( SecurityPlan securityPlan, BoltSer
181181
SessionFactory sessionFactory = createSessionFactory( connectionProvider, retryLogic, config );
182182
InternalDriver driver = createDriver(securityPlan, sessionFactory, metrics, config);
183183
Logger log = config.logging().getLog( Driver.class.getSimpleName() );
184-
log.info( "Routing driver instance %s created for server address %s", driver, address.toString() );
184+
log.info( "Routing driver instance %s created for server address %s", driver.hashCode(), address );
185185
return driver;
186186
}
187187

driver/src/main/java/org/neo4j/driver/internal/InternalDriver.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public CompletionStage<Void> closeAsync()
115115
{
116116
if ( closed.compareAndSet( false, true ) )
117117
{
118-
log.info( "Closing driver instance %s", this );
118+
log.info( "Closing driver instance %s", hashCode() );
119119
return sessionFactory.close();
120120
}
121121
return completedWithNull();

0 commit comments

Comments
 (0)