Skip to content

Commit bc1baba

Browse files
author
Zhen Li
committed
Updated more deprecated methods to new ones
1 parent 1110bdd commit bc1baba

File tree

5 files changed

+15
-16
lines changed

5 files changed

+15
-16
lines changed

driver/src/test/java/org/neo4j/driver/integration/SummaryIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,8 +141,8 @@ void shouldGetSystemUpdates() throws Throwable
141141
try ( Session session = neo4j.driver().session( forDatabase( "system" ) ) )
142142
{
143143
StatementResult result = session.run( "CREATE USER foo SET PASSWORD 'bar'" );
144-
assertThat( result.summary().counters().containsUpdates(), equalTo( false ) );
145-
assertThat( result.summary().counters().containsSystemUpdates(), equalTo( true ) );
144+
assertThat( result.consume().counters().containsUpdates(), equalTo( false ) );
145+
assertThat( result.consume().counters().containsSystemUpdates(), equalTo( true ) );
146146
}
147147
}
148148

driver/src/test/java/org/neo4j/driver/integration/reactive/RxTransactionIT.java

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ void shouldBePossibleToRunSingleStatementAndCommit()
123123
Flux<Integer> ids = Flux.usingWhen( session.beginTransaction(),
124124
tx -> Flux.from( tx.run( "CREATE (n:Node {id: 42}) RETURN n" ).records() )
125125
.map( record -> record.get( 0 ).asNode().get( "id" ).asInt() ),
126-
RxTransaction::commit, RxTransaction::rollback );
126+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null );
127127

128128
StepVerifier.create( ids ).expectNext( 42 ).verifyComplete();
129129
assertEquals( 1, countNodes( 42 ) );
@@ -348,7 +348,7 @@ void shouldAllowRollbackAfterFailedCommit()
348348
{
349349
Flux<Record> records = Flux.usingWhen( session.beginTransaction(),
350350
tx -> Flux.from( tx.run( "WRONG" ).records() ),
351-
RxTransaction::commit, RxTransaction::rollback );
351+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null );
352352

353353
StepVerifier.create( records ).verifyErrorSatisfies( error ->
354354
assertThat( error.getMessage(), containsString( "Invalid input" ) ) );
@@ -501,7 +501,7 @@ void shouldFailForEachWhenActionFails()
501501
Flux<Record> records = Flux.usingWhen( session.beginTransaction(),
502502
tx -> Flux.from( tx.run( "RETURN 'Hi!'" ).records() ).doOnNext( record -> { throw e; } ),
503503
RxTransaction::commit,
504-
RxTransaction::rollback );
504+
( tx, error ) -> tx.rollback(), null );
505505

506506
StepVerifier.create( records ).expectErrorSatisfies( error -> assertEquals( e, error ) ).verify();
507507
}
@@ -546,7 +546,7 @@ void shouldFailWhenListTransformationFunctionFails()
546546

547547
Flux<Object> records = Flux.usingWhen( session.beginTransaction(),
548548
tx -> Flux.from( tx.run( "RETURN 'Hi!'" ).records() ).map( record -> { throw e; } ),
549-
RxTransaction::commit, RxTransaction::rollback );
549+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null );
550550

551551
StepVerifier.create( records ).expectErrorSatisfies( error -> {
552552
assertEquals( e, error );
@@ -680,7 +680,7 @@ void shouldUpdateSessionBookmarkAfterCommit()
680680
await( Flux.usingWhen( session.beginTransaction(),
681681
tx -> tx.run( "CREATE (:MyNode)" ).records(),
682682
RxTransaction::commit,
683-
RxTransaction::rollback ) );
683+
( tx, error ) -> tx.rollback(), null ) );
684684

685685
Bookmark bookmarkAfter = session.lastBookmark();
686686

@@ -795,7 +795,6 @@ private int countNodes( Object id )
795795

796796
private void testForEach( String query, int expectedSeenRecords )
797797
{
798-
799798
Flux<ResultSummary> summary = Flux.usingWhen( session.beginTransaction(), tx -> {
800799
RxStatementResult result = tx.run( query );
801800
AtomicInteger recordsSeen = new AtomicInteger();
@@ -808,7 +807,7 @@ private void testForEach( String query, int expectedSeenRecords )
808807
assertEquals( emptyMap(), s.statement().parameters().asMap() );
809808
assertEquals( expectedSeenRecords, recordsSeen.get() );
810809
} );
811-
}, RxTransaction::commit, RxTransaction::rollback );
810+
}, RxTransaction::commit, ( tx, error ) -> tx.rollback(), null );
812811

813812
StepVerifier.create( summary ).expectNextCount( 1 ).verifyComplete(); // we indeed get a summary.
814813
}
@@ -820,7 +819,7 @@ private <T> void testList( String query, List<T> expectedList )
820819
Flux<List<Record>> records = Flux.usingWhen( session.beginTransaction(),
821820
tx -> Flux.from( tx.run( query ).records() ).collectList(),
822821
RxTransaction::commit,
823-
RxTransaction::rollback );
822+
( tx, error ) -> tx.rollback(), null );
824823

825824
StepVerifier.create( records.single() ).consumeNextWith( allRecords -> {
826825
for ( Record record : allRecords )
@@ -836,9 +835,7 @@ private void testConsume( String query )
836835
{
837836
Flux<ResultSummary> summary = Flux.usingWhen( session.beginTransaction(), tx ->
838837
tx.run( query ).consume(),
839-
RxTransaction::commit,
840-
RxTransaction::rollback
841-
);
838+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null );
842839

843840
StepVerifier.create( summary.single() ).consumeNextWith( Assertions::assertNotNull ).verifyComplete();
844841
}

driver/src/test/java/org/neo4j/driver/stress/RxFailingQueryInTx.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public CompletionStage<Void> execute( C context )
4949
RxSession session = newSession( AccessMode.READ, context );
5050
Flux.usingWhen( session.beginTransaction(),
5151
tx -> tx.run( "UNWIND [10, 5, 0] AS x RETURN 10 / x" ).records(),
52-
RxTransaction::commit, RxTransaction::rollback )
52+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null )
5353
.subscribe( record -> {
5454
assertThat( record.get( 0 ).asInt(), either( equalTo( 1 ) ).or( equalTo( 2 ) ) );
5555
queryFinished.complete( null );

driver/src/test/java/org/neo4j/driver/stress/RxReadQueryInTx.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,8 @@ public CompletionStage<Void> execute( C context )
4545
{
4646
CompletableFuture<Void> queryFinished = new CompletableFuture<>();
4747
RxSession session = newSession( AccessMode.READ, context );
48-
Flux.usingWhen( session.beginTransaction(), this::processAndGetSummary, RxTransaction::commit, RxTransaction::rollback )
48+
Flux.usingWhen( session.beginTransaction(), this::processAndGetSummary,
49+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null )
4950
.subscribe( summary -> {
5051
context.readCompleted( summary );
5152
queryFinished.complete( null );

driver/src/test/java/org/neo4j/driver/stress/RxWriteQueryInTx.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,8 @@ public CompletionStage<Void> execute( C context )
4646
{
4747
CompletableFuture<Void> queryFinished = new CompletableFuture<>();
4848
RxSession session = newSession( AccessMode.WRITE, context );
49-
Flux.usingWhen( session.beginTransaction(), tx -> tx.run( "CREATE ()" ).consume(), RxTransaction::commit, RxTransaction::rollback ).subscribe(
49+
Flux.usingWhen( session.beginTransaction(), tx -> tx.run( "CREATE ()" ).consume(),
50+
RxTransaction::commit, ( tx, error ) -> tx.rollback(), null ).subscribe(
5051
summary -> {
5152
assertEquals( 1, summary.counters().nodesCreated() );
5253
context.nodeCreated();

0 commit comments

Comments
 (0)