Disable a few tests that are broken on 4.0 servers due to cypher not streaming records before error

Author: Zhen Li

driver/src/test/java/org/neo4j/driver/integration/ResultStreamIT.java

@@ -34,6 +34,7 @@
 import org.neo4j.driver.Value;
 import org.neo4j.driver.exceptions.ClientException;
 import org.neo4j.driver.exceptions.NoSuchRecordException;
+import org.neo4j.driver.internal.util.Neo4jFeature;
 import org.neo4j.driver.summary.ResultSummary;
 import org.neo4j.driver.util.ParallelizableIT;
 import org.neo4j.driver.util.SessionExtension;
@@ -281,6 +282,7 @@ void shouldConvertImmediatelyFailingStatementResultToStream()
     }
 
     @Test
+    @DisabledOnNeo4jWith( Neo4jFeature.NO_STREAMING )
     void shouldConvertEventuallyFailingStatementResultToStream()
     {
         List<Integer> seen = new ArrayList<>();

driver/src/test/java/org/neo4j/driver/integration/SessionIT.java

@@ -94,6 +94,7 @@
 import static org.neo4j.driver.internal.util.Matchers.arithmeticError;
 import static org.neo4j.driver.internal.util.Matchers.connectionAcquisitionTimeoutError;
 import static org.neo4j.driver.internal.util.Neo4jFeature.BOLT_V4;
+import static org.neo4j.driver.internal.util.Neo4jFeature.NO_STREAMING;
 import static org.neo4j.driver.util.DaemonThreadFactory.daemon;
 import static org.neo4j.driver.util.Neo4jRunner.DEFAULT_AUTH_TOKEN;
 
@@ -864,6 +865,7 @@ void shouldNotRetryOnConnectionAcquisitionTimeout()
     }
 
     @Test
+    @DisabledOnNeo4jWith( NO_STREAMING )
     void shouldAllowConsumingRecordsAfterFailureInSessionClose()
     {
         Session session = neo4j.driver().session();

driver/src/test/java/org/neo4j/driver/integration/async/AsyncSessionIT.java

@@ -80,6 +80,7 @@
 import static org.neo4j.driver.internal.util.Matchers.containsResultAvailableAfterAndResultConsumedAfter;
 import static org.neo4j.driver.internal.util.Matchers.syntaxError;
 import static org.neo4j.driver.internal.util.Neo4jFeature.BOLT_V3;
+import static org.neo4j.driver.internal.util.Neo4jFeature.NO_STREAMING;
 import static org.neo4j.driver.util.TestUtil.await;
 import static org.neo4j.driver.util.TestUtil.awaitAll;
 
@@ -155,6 +156,7 @@ void shouldFailForIncorrectQuery()
     }
 
     @Test
+    @DisabledOnNeo4jWith( NO_STREAMING )
     void shouldFailWhenQueryFailsAtRuntime()
     {
         StatementResultCursor cursor = await( session.runAsync( "UNWIND [1, 2, 0] AS x RETURN 10 / x" ) );

driver/src/test/java/org/neo4j/driver/integration/reactive/RxStatementResultIT.java

@@ -26,6 +26,7 @@
 
 import org.neo4j.driver.Record;
 import org.neo4j.driver.exceptions.ClientException;
+import org.neo4j.driver.internal.util.DisabledOnNeo4jWith;
 import org.neo4j.driver.internal.util.EnabledOnNeo4jWith;
 import org.neo4j.driver.reactive.RxStatementResult;
 import org.neo4j.driver.reactive.RxSession;
@@ -44,6 +45,7 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.neo4j.driver.Values.parameters;
 import static org.neo4j.driver.internal.util.Neo4jFeature.BOLT_V4;
+import static org.neo4j.driver.internal.util.Neo4jFeature.NO_STREAMING;
 
 @EnabledOnNeo4jWith( BOLT_V4 )
 @ParallelizableIT
@@ -281,6 +283,7 @@ void shouldDiscardRecords()
     }
 
     @Test
+    @DisabledOnNeo4jWith( NO_STREAMING )
     void shouldStreamCorrectRecordsBackBeforeError()
     {
         RxSession session = neo4j.driver().rxSession();

driver/src/test/java/org/neo4j/driver/internal/util/Neo4jFeature.java

@@ -19,8 +19,6 @@
 package org.neo4j.driver.internal.util;
 
 import static java.util.Objects.requireNonNull;
-import static org.neo4j.driver.internal.util.ServerVersion.v3_1_0;
-import static org.neo4j.driver.internal.util.ServerVersion.v3_2_0;
 import static org.neo4j.driver.internal.util.ServerVersion.v3_4_0;
 import static org.neo4j.driver.internal.util.ServerVersion.v3_5_0;
 import static org.neo4j.driver.internal.util.ServerVersion.v4_0_0;
@@ -30,7 +28,8 @@ public enum Neo4jFeature
     SPATIAL_TYPES( v3_4_0 ),
     TEMPORAL_TYPES( v3_4_0 ),
     BOLT_V3( v3_5_0 ),
-    BOLT_V4( v4_0_0 );
+    BOLT_V4( v4_0_0 ),
+    NO_STREAMING( v4_0_0 ); // the cypher cannot streaming records before error
 
     private final ServerVersion availableFromVersion;