Skip to content

Commit a8b609b

Browse files
authored
Update clirr configuration to check against previous version (#1381)
The `clirr-maven-plugin` configuration has been checking against `4.0.0` driver version for significant time. While it is useful in general, comparing against previous driver version (the default setting) has a benefit of making removals of public methods more visible in reviews.
1 parent 6dd7c0c commit a8b609b

File tree

7 files changed

+19
-13
lines changed

7 files changed

+19
-13
lines changed

bundle/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>org.neo4j.driver</groupId>
88
<artifactId>neo4j-java-driver-parent</artifactId>
9-
<version>5.5-SNAPSHOT</version>
9+
<version>5.6-SNAPSHOT</version>
1010
<relativePath>..</relativePath>
1111
</parent>
1212

driver/clirr-ignored-differences.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,12 @@
421421
<method>org.neo4j.driver.BookmarkManager queryBookmarkManager()</method>
422422
</difference>
423423

424+
<difference>
425+
<className>org/neo4j/driver/Driver</className>
426+
<differenceType>7002</differenceType>
427+
<method>org.neo4j.driver.BookmarkManager queryBookmarkManager()</method>
428+
</difference>
429+
424430
<difference>
425431
<className>org/neo4j/driver/Driver</className>
426432
<differenceType>7012</differenceType>

driver/pom.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>org.neo4j.driver</groupId>
88
<artifactId>neo4j-java-driver-parent</artifactId>
9-
<version>5.5-SNAPSHOT</version>
9+
<version>5.6-SNAPSHOT</version>
1010
</parent>
1111

1212
<artifactId>neo4j-java-driver</artifactId>
@@ -164,17 +164,17 @@
164164
<groupId>org.codehaus.mojo</groupId>
165165
<artifactId>clirr-maven-plugin</artifactId>
166166
<configuration>
167-
<comparisonArtifacts>
168-
<comparisonArtifact>
169-
<groupId>org.neo4j.driver</groupId>
170-
<artifactId>neo4j-java-driver</artifactId>
171-
<version>4.0.0</version>
172-
</comparisonArtifact>
173-
</comparisonArtifacts>
174167
<classesDirectory>${api.classes.directory}</classesDirectory>
175168
<excludes>org/neo4j/driver/internal/**</excludes>
176169
<ignoredDifferencesFile>clirr-ignored-differences.xml</ignoredDifferencesFile>
177170
</configuration>
171+
<dependencies>
172+
<dependency>
173+
<groupId>org.apache.bcel</groupId>
174+
<artifactId>bcel</artifactId>
175+
<version>6.7.0</version>
176+
</dependency>
177+
</dependencies>
178178
</plugin>
179179
</plugins>
180180
</pluginManagement>

examples/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>org.neo4j.driver</groupId>
88
<artifactId>neo4j-java-driver-parent</artifactId>
9-
<version>5.5-SNAPSHOT</version>
9+
<version>5.6-SNAPSHOT</version>
1010
</parent>
1111

1212
<groupId>org.neo4j.doc.driver</groupId>

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
<groupId>org.neo4j.driver</groupId>
77
<artifactId>neo4j-java-driver-parent</artifactId>
8-
<version>5.5-SNAPSHOT</version>
8+
<version>5.6-SNAPSHOT</version>
99

1010
<packaging>pom</packaging>
1111
<name>Neo4j Java Driver Project</name>

testkit-backend/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
<parent>
88
<artifactId>neo4j-java-driver-parent</artifactId>
99
<groupId>org.neo4j.driver</groupId>
10-
<version>5.5-SNAPSHOT</version>
10+
<version>5.6-SNAPSHOT</version>
1111
</parent>
1212

1313
<artifactId>testkit-backend</artifactId>

testkit-tests/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<parent>
77
<groupId>org.neo4j.driver</groupId>
88
<artifactId>neo4j-java-driver-parent</artifactId>
9-
<version>5.5-SNAPSHOT</version>
9+
<version>5.6-SNAPSHOT</version>
1010
<relativePath>..</relativePath>
1111
</parent>
1212

0 commit comments

Comments
 (0)