Skip to content

Commit 7a6d1c0

Browse files
authored
Add support for Optimization:ImplicitDefaultArguments feature (#1201)
This update excludes support for `qid` optimisation.
1 parent 05b50b0 commit 7a6d1c0

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ public class GetFeatures implements TestkitRequest
6666
"Feature:API:Driver.IsEncrypted",
6767
"Feature:API:SSLConfig",
6868
"Detail:DefaultSecurityConfigValueEquality",
69-
"Detail:ThrowOnMissingId"
69+
"Detail:ThrowOnMissingId",
70+
"Optimization:ImplicitDefaultArguments"
7071
) );
7172

7273
private static final Set<String> SYNC_FEATURES = new HashSet<>( Arrays.asList(

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,12 @@ public class StartTest implements TestkitRequest
6161
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestConnectionAcquisitionTimeoutMs\\.test_should_encompass_the_handshake_time.*$", skipMessage );
6262
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestConnectionAcquisitionTimeoutMs\\.test_should_fail_when_acquisition_timeout_is_reached_first.*$",
6363
skipMessage );
64+
skipMessage = "This test needs updating to implement expected behaviour";
65+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestAuthenticationSchemes\\.test_custom_scheme_empty$", skipMessage );
66+
skipMessage = "Driver does not implement optimization for qid in explicit transaction";
67+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments$", skipMessage );
68+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments_multi_query$", skipMessage );
69+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments_multi_query_nested$", skipMessage );
6470

6571
ASYNC_SKIP_PATTERN_TO_REASON.putAll( COMMON_SKIP_PATTERN_TO_REASON );
6672

0 commit comments

Comments
 (0)