Bolt refactoring

Author: injectives

driver/src/main/java/org/neo4j/driver/exceptions/ConnectionReadTimeoutException.java

@@ -39,6 +39,7 @@ public class ConnectionReadTimeoutException extends ServiceUnavailableException
      * @deprecated superseded by the {@link ConnectionReadTimeoutException#INSTANCE} value
      */
     @Deprecated
+    @SuppressWarnings("DeprecatedIsStillUsed")
     public ConnectionReadTimeoutException(String message) {
         super(message);
     }

driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java

@@ -72,7 +72,6 @@ public final Driver newInstance(
         return newInstance(uri, authTokenManager, clientCertificateManager, config, (SecurityPlan) null, null);
     }
 
-    @SuppressWarnings("deprecation")
     public final Driver newInstance(
             URI uri,
             AuthTokenManager authTokenManager,

driver/src/main/java/org/neo4j/driver/internal/InternalServerAddress.java

@@ -28,9 +28,9 @@ public record InternalServerAddress(String host, int port) implements ServerAddr
         requireValidPort(port);
     }
 
-    private static int requireValidPort(int port) {
+    private static void requireValidPort(int port) {
         if (port >= 0 && port <= 65_535) {
-            return port;
+            return;
         }
         throw new IllegalArgumentException("Illegal port: " + port);
     }
@@ -64,6 +64,7 @@ private static RuntimeException invalidAddressFormat(String address) {
         return new IllegalArgumentException("Invalid address format `" + address + "`");
     }
 
+    @SuppressWarnings("DuplicatedCode")
     private static URI uriFrom(String address) {
         String scheme;
         String hostPort;

driver/src/main/java/org/neo4j/driver/internal/SessionFactoryImpl.java

@@ -161,16 +161,6 @@ public CompletionStage<Boolean> supportsSessionAuth() {
                 .thenCompose(tuple -> connectionProvider.supportsSessionAuth(tuple.securityPlan(), tuple.authToken()));
     }
 
-    /**
-     * Get the underlying connection provider.
-     * <p>
-     * <b>This method is only for testing</b>
-     *
-     * @return the connection provider used by this factory.
-     */
-    //    public ConnectionProvider getConnectionProvider() {
-    //        return connectionProvider;
-    //    }
     private NetworkSession createSession(
             SecurityPlanManager securityPlanManager,
             BoltConnectionProvider connectionProvider,

driver/src/main/java/org/neo4j/driver/internal/async/BoltConnectionWithAuthTokenManager.java

@@ -233,6 +233,11 @@ public void onTelemetrySummary(TelemetrySummary summary) {
                 handler.onTelemetrySummary(summary);
             }
 
+            @Override
+            public void onIgnored() {
+                handler.onIgnored();
+            }
+
             @Override
             public void onComplete() {
                 handler.onComplete();

driver/src/main/java/org/neo4j/driver/internal/async/ConnectionContext.java

@@ -18,20 +18,14 @@
 
 import java.util.Set;
 import java.util.concurrent.CompletableFuture;
-import org.neo4j.driver.AccessMode;
 import org.neo4j.driver.AuthToken;
 import org.neo4j.driver.Bookmark;
 import org.neo4j.driver.internal.bolt.api.DatabaseName;
 
-/**
- * Describes what kind of connection to return by {@link ConnectionProvider}
- */
 public interface ConnectionContext {
 
     CompletableFuture<DatabaseName> databaseNameFuture();
 
-    AccessMode mode();
-
     Set<Bookmark> rediscoveryBookmarks();
 
     String impersonatedUser();

driver/src/main/java/org/neo4j/driver/internal/async/ImmutableConnectionContext.java

@@ -32,6 +32,7 @@
 import org.neo4j.driver.internal.bolt.api.DatabaseName;
 import org.neo4j.driver.internal.retry.RetryLogic;
 import org.neo4j.driver.internal.security.SecurityPlanManager;
+import org.neo4j.driver.internal.util.Futures;
 
 public class LeakLoggingNetworkSession extends NetworkSession {
     private final String stackTrace;
@@ -79,16 +80,15 @@ protected void finalize() throws Throwable {
     }
 
     private void logLeakIfNeeded() {
-        //        var isOpen = Futures.blockingGet(currentConnectionIsOpen());
-        //        if (isOpen) {
-        //            log.error(
-        //                    "Neo4j Session object leaked, please ensure that your application "
-        //                            + "fully consumes results in Sessions or explicitly calls `close` on Sessions
-        // before disposing of the objects.\n"
-        //                            + "Session was create at:\n"
-        //                            + stackTrace,
-        //                    null);
-        //        }
+        var isOpen = Futures.blockingGet(currentConnectionIsOpen());
+        if (isOpen) {
+            log.error(
+                    "Neo4j Session object leaked, please ensure that your application "
+                            + "fully consumes results in Sessions or explicitly calls `close` on Sessions before disposing of the objects.\n"
+                            + "Session was create at:\n"
+                            + stackTrace,
+                    null);
+        }
     }
 
     private static String captureStackTrace() {