Enable compilation failures on warnings for backend (#1279)

Author: injectives

testkit-backend/pom.xml

@@ -61,7 +61,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
                 <configuration>
-                    <compilerArgs combine.self="override"/>
+                    <compilerArgs combine.self="override">
+                        <arg>-Xlint:all,-processing</arg>
+                        <arg>-Werror</arg>
+                    </compilerArgs>
                 </configuration>
             </plugin>
             <plugin>

testkit-backend/src/main/java/neo4j/org/testkit/backend/CustomDriverError.java

@@ -18,7 +18,12 @@
  */
 package neo4j.org.testkit.backend;
 
+import java.io.Serial;
+
 public class CustomDriverError extends RuntimeException {
+    @Serial
+    private static final long serialVersionUID = 2979071989786663535L;
+
     public CustomDriverError(Throwable cause) {
         super(cause);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/FrontendError.java

@@ -18,4 +18,9 @@
  */
 package neo4j.org.testkit.backend;
 
-public class FrontendError extends RuntimeException {}
+import java.io.Serial;
+
+public class FrontendError extends RuntimeException {
+    @Serial
+    private static final long serialVersionUID = -8369933385092563391L;
+}

testkit-backend/src/main/java/neo4j/org/testkit/backend/holder/RxResultHolder.java

@@ -26,6 +26,7 @@
 import org.neo4j.driver.Record;
 import org.neo4j.driver.reactive.RxResult;
 
+@SuppressWarnings("deprecation")
 public class RxResultHolder extends AbstractResultHolder<RxSessionHolder, RxTransactionHolder, RxResult> {
     @Setter
     private RxBufferedSubscriber<Record> subscriber;

testkit-backend/src/main/java/neo4j/org/testkit/backend/holder/RxSessionHolder.java

@@ -21,6 +21,7 @@
 import org.neo4j.driver.SessionConfig;
 import org.neo4j.driver.reactive.RxSession;
 
+@SuppressWarnings("deprecation")
 public class RxSessionHolder extends AbstractSessionHolder<RxSession> {
     public RxSessionHolder(DriverHolder driverHolder, RxSession session, SessionConfig config) {
         super(driverHolder, session, config);

testkit-backend/src/main/java/neo4j/org/testkit/backend/holder/RxTransactionHolder.java

@@ -20,6 +20,7 @@
 
 import org.neo4j.driver.reactive.RxTransaction;
 
+@SuppressWarnings("deprecation")
 public class RxTransactionHolder extends AbstractTransactionHolder<RxSessionHolder, RxTransaction> {
     public RxTransactionHolder(RxSessionHolder sessionHolder, RxTransaction transaction) {
         super(sessionHolder, transaction);

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/TestkitModule.java

@@ -19,6 +19,7 @@
 package neo4j.org.testkit.backend.messages;
 
 import com.fasterxml.jackson.databind.module.SimpleModule;
+import java.io.Serial;
 import java.time.LocalDate;
 import java.util.List;
 import neo4j.org.testkit.backend.messages.requests.deserializer.TestkitCypherDateDeserializer;
@@ -57,6 +58,9 @@
 import org.neo4j.driver.types.IsoDuration;
 
 public class TestkitModule extends SimpleModule {
+    @Serial
+    private static final long serialVersionUID = 7051732358423895087L;
+
     public TestkitModule() {
         this.addDeserializer(List.class, new TestkitListDeserializer());
         this.addDeserializer(CypherDateTime.class, new TestkitCypherDateTimeDeserializer());

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/NewSession.java

@@ -105,6 +105,7 @@ private AsyncSessionHolder createAsyncSessionState(DriverHolder driverHolder, Se
                 driverHolder, driverHolder.getDriver().asyncSession(sessionConfig), sessionConfig);
     }
 
+    @SuppressWarnings("deprecation")
     private RxSessionHolder createRxSessionState(DriverHolder driverHolder, SessionConfig sessionConfig) {
         return new RxSessionHolder(driverHolder, driverHolder.getDriver().rxSession(sessionConfig), sessionConfig);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionBeginTransaction.java

@@ -88,6 +88,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState.getRxSessionHolder(data.getSessionId()).flatMap(sessionHolder -> {
             RxSession session = sessionHolder.getSession();

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionLastBookmarks.java

@@ -50,6 +50,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState
                 .getRxSessionHolder(data.getSessionId())

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionReadTransaction.java

@@ -48,6 +48,7 @@ public class SessionReadTransaction implements TestkitRequest {
     private SessionReadTransactionBody data;
 
     @Override
+    @SuppressWarnings("deprecation")
     public TestkitResponse process(TestkitState testkitState) {
         SessionHolder sessionHolder = testkitState.getSessionHolder(data.getSessionId());
         Session session = sessionHolder.getSession();
@@ -56,6 +57,7 @@ public TestkitResponse process(TestkitState testkitState) {
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState) {
         return testkitState
                 .getAsyncSessionHolder(data.getSessionId())
@@ -77,6 +79,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState
                 .getRxSessionHolder(data.getSessionId())
@@ -113,6 +116,7 @@ public Mono<TestkitResponse> processReactive(TestkitState testkitState) {
                 .then(Mono.just(retryableDone()));
     }
 
+    @SuppressWarnings("deprecation")
     private TransactionWork<Void> handle(TestkitState testkitState, SessionHolder sessionHolder) {
         return tx -> {
             String txId = testkitState.addTransactionHolder(new TransactionHolder(sessionHolder, tx));

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionRun.java

@@ -99,6 +99,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState.getRxSessionHolder(data.getSessionId()).flatMap(sessionHolder -> {
             RxSession session = sessionHolder.getSession();

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/SessionWriteTransaction.java

@@ -49,6 +49,7 @@ public class SessionWriteTransaction implements TestkitRequest {
     private SessionWriteTransactionBody data;
 
     @Override
+    @SuppressWarnings("deprecation")
     public TestkitResponse process(TestkitState testkitState) {
         SessionHolder sessionHolder = testkitState.getSessionHolder(data.getSessionId());
         Session session = sessionHolder.getSession();
@@ -57,6 +58,7 @@ public TestkitResponse process(TestkitState testkitState) {
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState) {
         return testkitState
                 .getAsyncSessionHolder(data.getSessionId())
@@ -78,6 +80,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState
                 .getRxSessionHolder(data.getSessionId())
@@ -114,6 +117,7 @@ public Mono<TestkitResponse> processReactive(TestkitState testkitState) {
                 .then(Mono.just(retryableDone()));
     }
 
+    @SuppressWarnings("deprecation")
     private TransactionWork<Void> handle(TestkitState testkitState, SessionHolder sessionHolder) {
         return tx -> {
             String txId = testkitState.addTransactionHolder(new TransactionHolder(sessionHolder, tx));

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/TransactionClose.java

@@ -49,6 +49,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState
                 .getRxTransactionHolder(data.getTxId())

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/TransactionRun.java

@@ -66,6 +66,7 @@ public CompletionStage<TestkitResponse> processAsync(TestkitState testkitState)
     }
 
     @Override
+    @SuppressWarnings("deprecation")
     public Mono<TestkitResponse> processRx(TestkitState testkitState) {
         return testkitState.getRxTransactionHolder(data.getTxId()).flatMap(transactionHolder -> {
             RxResult result = transactionHolder

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitCypherDateDeserializer.java

@@ -23,11 +23,15 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.time.LocalDate;
 import java.util.Date;
 
 public class TestkitCypherDateDeserializer extends StdDeserializer<LocalDate> {
 
+    @Serial
+    private static final long serialVersionUID = 3489940766207129614L;
+
     private final TestkitCypherTypeMapper mapper;
 
     public TestkitCypherDateDeserializer() {

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitCypherDateTimeDeserializer.java

@@ -23,9 +23,13 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import java.io.IOException;
+import java.io.Serial;
 import neo4j.org.testkit.backend.messages.requests.deserializer.types.CypherDateTime;
 
 public class TestkitCypherDateTimeDeserializer extends StdDeserializer<CypherDateTime> {
+    @Serial
+    private static final long serialVersionUID = 8980981682742682436L;
+
     private final TestkitCypherTypeMapper mapper;
 
     public TestkitCypherDateTimeDeserializer() {

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitCypherDurationDeserializer.java

@@ -23,10 +23,14 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import java.io.IOException;
+import java.io.Serial;
 import org.neo4j.driver.internal.InternalIsoDuration;
 import org.neo4j.driver.types.IsoDuration;
 
 public class TestkitCypherDurationDeserializer extends StdDeserializer<IsoDuration> {
+    @Serial
+    private static final long serialVersionUID = 3128342779161014747L;
+
     private final TestkitCypherTypeMapper mapper;
 
     public TestkitCypherDurationDeserializer() {

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitCypherParamDeserializer.java

@@ -26,12 +26,16 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.util.Collections;
 import java.util.HashMap;
 import java.util.Map;
 import neo4j.org.testkit.backend.messages.requests.deserializer.types.CypherType;
 
 public class TestkitCypherParamDeserializer extends StdDeserializer<Map<String, Object>> {
+    @Serial
+    private static final long serialVersionUID = -3239342714470961079L;
+
     public TestkitCypherParamDeserializer() {
         super(Map.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitCypherTimeDeserializer.java

@@ -23,9 +23,13 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import java.io.IOException;
+import java.io.Serial;
 import neo4j.org.testkit.backend.messages.requests.deserializer.types.CypherTime;
 
 public class TestkitCypherTimeDeserializer extends StdDeserializer<CypherTime> {
+    @Serial
+    private static final long serialVersionUID = 8354352358618500970L;
+
     private final TestkitCypherTypeMapper mapper;
 
     public TestkitCypherTimeDeserializer() {

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/deserializer/TestkitListDeserializer.java

@@ -26,11 +26,15 @@
 import com.fasterxml.jackson.databind.DeserializationContext;
 import com.fasterxml.jackson.databind.deser.std.StdDeserializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.util.ArrayList;
 import java.util.List;
 import neo4j.org.testkit.backend.messages.requests.deserializer.types.CypherType;
 
 public class TestkitListDeserializer extends StdDeserializer<List<?>> {
+    @Serial
+    private static final long serialVersionUID = -1878499456593526741L;
+
     private final TestkitCypherParamDeserializer mapDeserializer;
 
     public TestkitListDeserializer() {

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitDateTimeValueSerializer.java

@@ -24,12 +24,16 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.time.ZoneId;
 import java.time.ZoneOffset;
 import java.time.ZonedDateTime;
 import org.neo4j.driver.internal.value.DateTimeValue;
 
 public class TestkitDateTimeValueSerializer extends StdSerializer<DateTimeValue> {
+    @Serial
+    private static final long serialVersionUID = 819438767898259613L;
+
     public TestkitDateTimeValueSerializer() {
         super(DateTimeValue.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitDateValueSerializer.java

@@ -24,10 +24,14 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.time.LocalDate;
 import org.neo4j.driver.internal.value.DateValue;
 
 public class TestkitDateValueSerializer extends StdSerializer<DateValue> {
+    @Serial
+    private static final long serialVersionUID = 6317556585191107633L;
+
     public TestkitDateValueSerializer() {
         super(DateValue.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitDurationValueSerializer.java

@@ -24,10 +24,14 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import org.neo4j.driver.internal.value.DurationValue;
 import org.neo4j.driver.types.IsoDuration;
 
 public class TestkitDurationValueSerializer extends StdSerializer<DurationValue> {
+    @Serial
+    private static final long serialVersionUID = -4371898769147355036L;
+
     public TestkitDurationValueSerializer() {
         super(DurationValue.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitListValueSerializer.java

@@ -25,10 +25,14 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.util.function.Function;
 import org.neo4j.driver.internal.value.ListValue;
 
 public class TestkitListValueSerializer extends StdSerializer<ListValue> {
+    @Serial
+    private static final long serialVersionUID = -5564826952797323279L;
+
     public TestkitListValueSerializer() {
         super(ListValue.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitLocalDateTimeValueSerializer.java

@@ -24,10 +24,14 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.time.LocalDateTime;
 import org.neo4j.driver.internal.value.LocalDateTimeValue;
 
 public class TestkitLocalDateTimeValueSerializer extends StdSerializer<LocalDateTimeValue> {
+    @Serial
+    private static final long serialVersionUID = 8864167921883077348L;
+
     public TestkitLocalDateTimeValueSerializer() {
         super(LocalDateTimeValue.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitLocalTimeValueSerializer.java

@@ -24,10 +24,14 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.time.LocalTime;
 import org.neo4j.driver.internal.value.LocalTimeValue;
 
 public class TestkitLocalTimeValueSerializer extends StdSerializer<LocalTimeValue> {
+    @Serial
+    private static final long serialVersionUID = -3712440793854179552L;
+
     public TestkitLocalTimeValueSerializer() {
         super(LocalTimeValue.class);
     }

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/responses/serializer/TestkitMapValueSerializer.java

@@ -25,12 +25,16 @@
 import com.fasterxml.jackson.databind.SerializerProvider;
 import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import java.io.IOException;
+import java.io.Serial;
 import java.util.Map;
 import java.util.function.Function;
 import org.neo4j.driver.Value;
 import org.neo4j.driver.internal.value.MapValue;
 
 public class TestkitMapValueSerializer extends StdSerializer<MapValue> {
+    @Serial
+    private static final long serialVersionUID = 3405706388191274032L;
+
     public TestkitMapValueSerializer() {
         super(MapValue.class);
     }