Added unit tests for NettyChannelInitializer

Author: lutovich

driver/src/main/java/org/neo4j/driver/internal/async/ChannelConnectedListener.java

@@ -55,15 +55,11 @@ public void operationComplete( ChannelFuture future )
             channel.pipeline().addLast( new HandshakeResponseHandler( handshakeCompletedPromise, logging ) );
             ChannelFuture handshakeFuture = channel.writeAndFlush( handshake() );
 
-            handshakeFuture.addListener( new ChannelFutureListener()
+            handshakeFuture.addListener( channelFuture ->
             {
-                @Override
-                public void operationComplete( ChannelFuture future ) throws Exception
+                if ( !channelFuture.isSuccess() )
                 {
-                    if ( !future.isSuccess() )
-                    {
-                        handshakeCompletedPromise.setFailure( future.cause() );
-                    }
+                    handshakeCompletedPromise.setFailure( channelFuture.cause() );
                 }
             } );
         }

driver/src/main/java/org/neo4j/driver/internal/async/HandshakeResponseHandler.java

@@ -54,13 +54,13 @@ public HandshakeResponseHandler( ChannelPromise handshakeCompletedPromise, Loggi
     }
 
     @Override
-    public void exceptionCaught( ChannelHandlerContext ctx, Throwable cause ) throws Exception
+    public void exceptionCaught( ChannelHandlerContext ctx, Throwable cause )
     {
         fail( ctx, cause );
     }
 
     @Override
-    protected void decode( ChannelHandlerContext ctx, ByteBuf in, List<Object> out ) throws Exception
+    protected void decode( ChannelHandlerContext ctx, ByteBuf in, List<Object> out )
     {
         int serverSuggestedVersion = in.readInt();
         log.debug( "Server suggested protocol version: %s", serverSuggestedVersion );

driver/src/test/java/org/neo4j/driver/internal/async/NettyChannelInitializerTest.java

@@ -0,0 +1,97 @@
+/*
+ * Copyright (c) 2002-2017 "Neo Technology,"
+ * Network Engine for Objects in Lund AB [http://neotechnology.com]
+ *
+ * This file is part of Neo4j.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.neo4j.driver.internal.async;
+
+import io.netty.channel.embedded.EmbeddedChannel;
+import io.netty.channel.pool.ChannelPoolHandler;
+import io.netty.handler.ssl.SslHandler;
+import org.junit.Test;
+
+import org.neo4j.driver.internal.security.SecurityPlan;
+import org.neo4j.driver.internal.util.Clock;
+import org.neo4j.driver.internal.util.FakeClock;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.when;
+import static org.neo4j.driver.internal.async.ChannelAttributes.address;
+import static org.neo4j.driver.internal.async.ChannelAttributes.creationTimestamp;
+import static org.neo4j.driver.internal.async.ChannelAttributes.messageDispatcher;
+import static org.neo4j.driver.internal.net.BoltServerAddress.LOCAL_DEFAULT;
+
+public class NettyChannelInitializerTest
+{
+    @Test
+    public void shouldAddSslHandlerWhenRequiresEncryption() throws Exception
+    {
+        SecurityPlan securityPlan = SecurityPlan.forAllCertificates();
+        NettyChannelInitializer initializer = new NettyChannelInitializer( LOCAL_DEFAULT, securityPlan,
+                mock( ChannelPoolHandler.class ), new FakeClock() );
+
+        EmbeddedChannel channel = new EmbeddedChannel();
+        initializer.initChannel( channel );
+
+        assertNotNull( channel.pipeline().get( SslHandler.class ) );
+    }
+
+    @Test
+    public void shouldNotAddSslHandlerWhenDoesNotRequireEncryption() throws Exception
+    {
+        SecurityPlan securityPlan = SecurityPlan.insecure();
+        NettyChannelInitializer initializer = new NettyChannelInitializer( LOCAL_DEFAULT, securityPlan,
+                mock( ChannelPoolHandler.class ), new FakeClock() );
+
+        EmbeddedChannel channel = new EmbeddedChannel();
+        initializer.initChannel( channel );
+
+        assertNull( channel.pipeline().get( SslHandler.class ) );
+    }
+
+    @Test
+    public void shouldUpdateChannelAttributes() throws Exception
+    {
+        Clock clock = mock( Clock.class );
+        when( clock.millis() ).thenReturn( 42L );
+        NettyChannelInitializer initializer = new NettyChannelInitializer( LOCAL_DEFAULT, SecurityPlan.insecure(),
+                mock( ChannelPoolHandler.class ), clock );
+
+        EmbeddedChannel channel = new EmbeddedChannel();
+        initializer.initChannel( channel );
+
+        assertEquals( LOCAL_DEFAULT, address( channel ) );
+        assertEquals( 42L, creationTimestamp( channel ) );
+        assertNotNull( messageDispatcher( channel ) );
+    }
+
+    @Test
+    public void shouldNotifyPoolHandlerAboutCreatedConnection() throws Exception
+    {
+        ChannelPoolHandler poolHandler = mock( ChannelPoolHandler.class );
+        NettyChannelInitializer initializer = new NettyChannelInitializer( LOCAL_DEFAULT, SecurityPlan.insecure(),
+                poolHandler, new FakeClock() );
+
+        EmbeddedChannel channel = new EmbeddedChannel();
+        initializer.initChannel( channel );
+
+        verify( poolHandler ).channelCreated( channel );
+    }
+}