Better naming of a config method

Renamed `withSessionLivenessCheckTimeout` to `withConnectionLivenessCheckTimeout`
because all other methods refer to connections instead of sessions and are
actually settings for the connection pool and not session pool.

Author: lutovich

driver/src/main/java/org/neo4j/driver/v1/Config.java

@@ -261,18 +261,18 @@ public ConfigBuilder withMaxIdleSessions( int size )
         }
 
         /**
-         * Please use {@link #withSessionLivenessCheckTimeout(long, TimeUnit)}.
+         * Please use {@link #withConnectionLivenessCheckTimeout(long, TimeUnit)}.
          *
          * @param timeout minimum idle time in milliseconds
          * @return this builder
-         * @see #withSessionLivenessCheckTimeout(long, TimeUnit)
-         * @deprecated please use overloaded method with {@link TimeUnit} parameter. This method will be removed in
-         * future release.
+         * @see #withConnectionLivenessCheckTimeout(long, TimeUnit)
+         * @deprecated please use {@link #withConnectionLivenessCheckTimeout(long, TimeUnit)} method. This method
+         * will be removed in future release.
          */
         @Deprecated
         public ConfigBuilder withSessionLivenessCheckTimeout( long timeout )
         {
-            withSessionLivenessCheckTimeout( timeout, TimeUnit.MILLISECONDS );
+            withConnectionLivenessCheckTimeout( timeout, TimeUnit.MILLISECONDS );
             return this;
         }
 
@@ -298,7 +298,7 @@ public ConfigBuilder withSessionLivenessCheckTimeout( long timeout )
          * @param unit the unit in which the duration is given
          * @return this builder
          */
-        public ConfigBuilder withSessionLivenessCheckTimeout( long value, TimeUnit unit )
+        public ConfigBuilder withConnectionLivenessCheckTimeout( long value, TimeUnit unit )
         {
             long idleTimeBeforeConnectionTestMillis = unit.toMillis( value );
             if ( idleTimeBeforeConnectionTestMillis <= 0 )

driver/src/test/java/org/neo4j/driver/internal/ConfigTest.java

@@ -85,7 +85,7 @@ public void shouldChangeToTrustedCert()
     @Test
     public void shouldSupportLivenessCheckTimeoutSetting() throws Throwable
     {
-        Config config = Config.build().withSessionLivenessCheckTimeout( 42, TimeUnit.SECONDS ).toConfig();
+        Config config = Config.build().withConnectionLivenessCheckTimeout( 42, TimeUnit.SECONDS ).toConfig();
 
         assertEquals( TimeUnit.SECONDS.toMillis( 42 ), config.idleTimeBeforeConnectionTest() );
     }
@@ -97,7 +97,7 @@ public void shouldThrowForZeroTimeoutInLivenessCheckTimeoutSetting() throws Thro
 
         try
         {
-            builder.withSessionLivenessCheckTimeout( 0, TimeUnit.SECONDS );
+            builder.withConnectionLivenessCheckTimeout( 0, TimeUnit.SECONDS );
             fail( "Exception expected" );
         }
         catch ( Exception e )
@@ -113,7 +113,7 @@ public void shouldThrowForNegativeTimeoutInLivenessCheckTimeoutSetting() throws
 
         try
         {
-            builder.withSessionLivenessCheckTimeout( -42, TimeUnit.SECONDS );
+            builder.withConnectionLivenessCheckTimeout( -42, TimeUnit.SECONDS );
             fail( "Exception expected" );
         }
         catch ( Exception e )

driver/src/test/java/org/neo4j/driver/v1/integration/CausalClusteringIT.java

@@ -201,7 +201,7 @@ public void shouldDropBrokenOldSessions() throws Exception
         int livenessCheckTimeoutMinutes = 2;
 
         Config config = Config.build()
-                .withSessionLivenessCheckTimeout( livenessCheckTimeoutMinutes, TimeUnit.MINUTES )
+                .withConnectionLivenessCheckTimeout( livenessCheckTimeoutMinutes, TimeUnit.MINUTES )
                 .withEncryptionLevel( Config.EncryptionLevel.NONE )
                 .toConfig();
 

driver/src/test/java/org/neo4j/driver/v1/integration/ServerKilledIT.java

@@ -96,7 +96,7 @@ public void shouldDropBrokenOldSessions() throws Throwable
         // config with set liveness check timeout
         int livenessCheckTimeoutMinutes = 10;
         Config config = Config.build()
-                .withSessionLivenessCheckTimeout( livenessCheckTimeoutMinutes, TimeUnit.MINUTES )
+                .withConnectionLivenessCheckTimeout( livenessCheckTimeoutMinutes, TimeUnit.MINUTES )
                 .withEncryptionLevel( Config.EncryptionLevel.NONE )
                 .toConfig();
 

driver/src/test/java/org/neo4j/driver/v1/util/cc/Cluster.java

@@ -289,7 +289,7 @@ private static Config driverConfig()
                 .withTrustStrategy( trustAllCertificates() )
                 .withEncryptionLevel( Config.EncryptionLevel.NONE )
                 .withMaxIdleSessions( 1 )
-                .withSessionLivenessCheckTimeout( TimeUnit.HOURS.toMillis( 1 ) )
+                .withConnectionLivenessCheckTimeout( 1, TimeUnit.HOURS )
                 .toConfig();
     }