Skip to content

Commit 468b39f

Browse files
authored
Add support for Optimization:ImplicitDefaultArguments feature (#1201) (#1202)
This update excludes support for `qid` optimisation.
1 parent e47b908 commit 468b39f

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ public class GetFeatures implements TestkitRequest
6565
"Optimization:EagerTransactionBegin",
6666
"Feature:API:Driver.IsEncrypted",
6767
"Feature:API:SSLConfig",
68-
"Detail:DefaultSecurityConfigValueEquality"
68+
"Detail:DefaultSecurityConfigValueEquality",
69+
"Optimization:ImplicitDefaultArguments"
6970
) );
7071

7172
private static final Set<String> SYNC_FEATURES = new HashSet<>( Arrays.asList(

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,12 @@ public class StartTest implements TestkitRequest
5555
String skipMessage = "This test expects hostname verification to be turned off when all certificates are trusted";
5656
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestTrustAllCertsConfig\\.test_trusted_ca_wrong_hostname$", skipMessage );
5757
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestTrustAllCertsConfig\\.test_untrusted_ca_wrong_hostname$", skipMessage );
58+
skipMessage = "This test needs updating to implement expected behaviour";
59+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestAuthenticationSchemes\\.test_custom_scheme_empty$", skipMessage );
60+
skipMessage = "Driver does not implement optimization for qid in explicit transaction";
61+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments$", skipMessage );
62+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments_multi_query$", skipMessage );
63+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestOptimizations\\.test_uses_implicit_default_arguments_multi_query_nested$", skipMessage );
5864

5965
ASYNC_SKIP_PATTERN_TO_REASON.putAll( COMMON_SKIP_PATTERN_TO_REASON );
6066
ASYNC_SKIP_PATTERN_TO_REASON.put( "^.*\\.test_should_reject_server_using_verify_connectivity_bolt_3x0$", "Does not error as expected" );

0 commit comments

Comments
 (0)