Skip to content

Commit 3b76308

Browse files
committed
Remove "Temporary:ConnectionAcquisitionTimeout" TestKit flag
1 parent ab7bea0 commit 3b76308

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,13 +55,13 @@ public class GetFeatures implements TestkitRequest
5555
"Feature:API:SSLSchemes",
5656
"Feature:API:Liveness.Check",
5757
"Temporary:DriverMaxConnectionPoolSize",
58-
"Temporary:ConnectionAcquisitionTimeout",
5958
"Temporary:GetConnectionPoolMetrics",
6059
"Temporary:CypherPathAndRelationship",
6160
"Temporary:FullSummary",
6261
"Temporary:ResultKeys",
6362
"Temporary:TransactionClose",
6463
"Optimization:EagerTransactionBegin",
64+
"Feature:API:ConnectionAcquisitionTimeout",
6565
"Feature:API:Driver.IsEncrypted",
6666
"Feature:API:SSLConfig",
6767
"Detail:DefaultSecurityConfigValueEquality"

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,11 @@ public class StartTest implements TestkitRequest
5858
String skipMessage = "This test expects hostname verification to be turned off when all certificates are trusted";
5959
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestTrustAllCertsConfig\\.test_trusted_ca_wrong_hostname$", skipMessage );
6060
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestTrustAllCertsConfig\\.test_untrusted_ca_wrong_hostname$", skipMessage );
61+
skipMessage = "Driver handles connection acquisition timeout differently";
62+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestConnectionAcquisitionTimeoutMs\\.test_should_encompass_the_handshake_time.*$", skipMessage );
63+
COMMON_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestConnectionAcquisitionTimeoutMs\\.test_should_fail_when_acquisition_timeout_is_reached_first.*$",
64+
skipMessage );
65+
6166
ASYNC_SKIP_PATTERN_TO_REASON.putAll( COMMON_SKIP_PATTERN_TO_REASON );
6267

6368
REACTIVE_SKIP_PATTERN_TO_REASON.putAll( COMMON_SKIP_PATTERN_TO_REASON );

0 commit comments

Comments
 (0)