Fix NettyChannelTracker race condition when tracking new channels (#904) (#906)

This update fixes an issue when `SimpleChannelPool` may invoke the `channelAcquired` method before the `channelCreated` method is called. Since it violates `NettyChannelTracker` contract, it may result in runtime failures.

See the following for details:
```
@startuml
T1 -> SimpleChannelPool: acquireHealthyFromPoolOrNew
activate SimpleChannelPool

SimpleChannelPool -> NettyChannelPool: connectChannel
activate NettyChannelPool

NettyChannelPool -> ChannelFuture: addListener
activate ChannelFuture

ChannelFuture --> NettyChannelPool:
deactivate ChannelFuture

NettyChannelPool --> SimpleChannelPool:
deactivate NettyChannelPool

T2 -> ChannelFuture: setSuccess
activate ChannelFuture

ChannelFuture -> ChannelFuture: done
activate ChannelFuture

ChannelFuture --> ChannelFuture:
deactivate ChannelFuture

SimpleChannelPool -> ChannelFuture: isDone
activate ChannelFuture

ChannelFuture --> SimpleChannelPool:
deactivate ChannelFuture

alt isDone case
    SimpleChannelPool -> NettyChannelTracker: channelAcquired
    activate NettyChannelTracker

    NettyChannelTracker --> SimpleChannelPool:
    deactivate NettyChannelTracker
end

SimpleChannelPool --> T1:
deactivate SimpleChannelPool

ChannelFuture -> NettyChannelTracker: channelCreated
activate NettyChannelTracker

NettyChannelTracker -> ChannelFuture:
deactivate NettyChannelTracker

ChannelFuture -> T2:
deactivate ChannelFuture
@enduml
```

Author: injectives

driver/src/main/java/org/neo4j/driver/internal/async/pool/NettyChannelPool.java

@@ -21,6 +21,7 @@
 import io.netty.bootstrap.Bootstrap;
 import io.netty.channel.Channel;
 import io.netty.channel.ChannelFuture;
+import io.netty.channel.ChannelPromise;
 import io.netty.channel.pool.ChannelHealthChecker;
 import io.netty.channel.pool.FixedChannelPool;
 
@@ -66,21 +67,27 @@ public class NettyChannelPool implements ExtendedChannelPool
             protected ChannelFuture connectChannel( Bootstrap bootstrap )
             {
                 ListenerEvent creatingEvent = handler.channelCreating( id );
-                ChannelFuture channelFuture = connector.connect( address, bootstrap );
-                channelFuture.addListener( future -> {
-                    if ( future.isSuccess() )
-                    {
-                        // notify pool handler about a successful connection
-                        Channel channel = channelFuture.channel();
-                        setPoolId( channel, id );
-                        handler.channelCreated( channel, creatingEvent );
-                    }
-                    else
-                    {
-                        handler.channelFailedToCreate( id );
-                    }
-                } );
-                return channelFuture;
+                ChannelFuture connectedChannelFuture = connector.connect( address, bootstrap );
+                Channel channel = connectedChannelFuture.channel();
+                // This ensures that handler.channelCreated is called before SimpleChannelPool calls handler.channelAcquired
+                ChannelPromise trackedChannelFuture = channel.newPromise();
+                connectedChannelFuture.addListener(
+                        future ->
+                        {
+                            if ( future.isSuccess() )
+                            {
+                                // notify pool handler about a successful connection
+                                setPoolId( channel, id );
+                                handler.channelCreated( channel, creatingEvent );
+                                trackedChannelFuture.setSuccess();
+                            }
+                            else
+                            {
+                                handler.channelFailedToCreate( id );
+                                trackedChannelFuture.setFailure( future.cause() );
+                            }
+                        } );
+                return trackedChannelFuture;
             }
         };
     }