Update

Author: injectives

driver/src/main/java/org/neo4j/driver/internal/async/NetworkSession.java

@@ -311,7 +311,6 @@ public CompletionStage<UnmanagedTransaction> beginTransactionAsync(
         return newTransactionStage;
     }
 
-    @SuppressWarnings("ThrowableNotThrown")
     public CompletionStage<Void> resetAsync() {
         return existingTransactionOrNull()
                 .thenAccept(tx -> {

driver/src/main/java/org/neo4j/driver/internal/async/UnmanagedTransaction.java

@@ -302,7 +302,6 @@ private void addSuppressedWhenNotCaptured(Throwable currentCause, Throwable newC
         }
     }
 
-    @SuppressWarnings("ThrowableNotThrown")
     public CompletionStage<Void> terminateAsync() {
         return executeWithLock(lock, () -> {
             if (!isOpen() || commitFuture != null || rollbackFuture != null) {

driver/src/main/java/org/neo4j/driver/internal/reactive/InternalReactiveTransaction.java

@@ -35,7 +35,7 @@ protected InternalReactiveTransaction(UnmanagedTransaction tx) {
     }
 
     @Override
-    @SuppressWarnings({"ThrowableNotThrown", "DuplicatedCode"})
+    @SuppressWarnings({"DuplicatedCode"})
     public Publisher<ReactiveResult> run(Query query) {
         CompletionStage<RxResultCursor> cursorStage;
         try {

driver/src/main/java/org/neo4j/driver/internal/reactive/InternalRxTransaction.java

@@ -33,7 +33,6 @@ public InternalRxTransaction(UnmanagedTransaction tx) {
     }
 
     @Override
-    @SuppressWarnings("ThrowableNotThrown")
     public RxResult run(Query query) {
         return new InternalRxResult(() -> {
             var cursorFuture = new CompletableFuture<RxResultCursor>();

driver/src/main/java/org/neo4j/driver/internal/reactivestreams/InternalReactiveTransaction.java

@@ -34,7 +34,7 @@ protected InternalReactiveTransaction(UnmanagedTransaction tx) {
     }
 
     @Override
-    @SuppressWarnings({"ThrowableNotThrown", "DuplicatedCode"})
+    @SuppressWarnings({"DuplicatedCode"})
     public Publisher<ReactiveResult> run(Query query) {
         CompletionStage<RxResultCursor> cursorStage;
         try {

driver/src/test/java/org/neo4j/driver/integration/UnmanagedTransactionIT.java

@@ -105,7 +105,6 @@ void shouldFailToCommitAfterRollback() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldFailToCommitAfterTermination() {
         var tx = beginTransaction();
 
@@ -137,7 +136,6 @@ void shouldFailToRollbackAfterCommit() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldRollbackAfterTermination() {
         var tx = beginTransaction();
 
@@ -148,7 +146,6 @@ void shouldRollbackAfterTermination() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldFailToRunQueryWhenTerminated() {
         var tx = beginTransaction();
         txRun(tx, "CREATE (:MyLabel)");
@@ -161,7 +158,6 @@ void shouldFailToRunQueryWhenTerminated() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldBePossibleToRunMoreTransactionsAfterOneIsTerminated() {
         var tx1 = beginTransaction();
         tx1.markTerminated(null);

driver/src/test/java/org/neo4j/driver/internal/async/UnmanagedTransactionTest.java

@@ -198,7 +198,6 @@ void shouldBeOpenAfterConstruction() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldBeClosedWhenMarkedAsTerminated() {
         var connection = connectionMock();
         given(connection.beginTransaction(any(), any(), any(), any(), any(), any(), any(), any()))
@@ -215,7 +214,6 @@ void shouldBeClosedWhenMarkedAsTerminated() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldBeClosedWhenMarkedTerminatedAndClosed() {
         var connection = connectionMock();
         given(connection.beginTransaction(any(), any(), any(), any(), any(), any(), any(), any()))
@@ -296,7 +294,6 @@ void shouldNotReleaseConnectionWhenBeginSucceeds() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldReleaseConnectionWhenTerminatedAndCommitted() {
         var connection = connectionMock();
         given(connection.close()).willReturn(CompletableFuture.completedStage(null));
@@ -321,7 +318,6 @@ void shouldReleaseConnectionWhenTerminatedAndCommitted() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldNotCreateCircularExceptionWhenTerminationCauseEqualsToCursorFailure() {
         var connection = connectionMock();
         given(connection.close()).willReturn(CompletableFuture.completedStage(null));
@@ -349,7 +345,6 @@ void shouldNotCreateCircularExceptionWhenTerminationCauseEqualsToCursorFailure()
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldNotCreateCircularExceptionWhenTerminationCauseDifferentFromCursorFailure() {
         var connection = connectionMock();
         given(connection.close()).willReturn(CompletableFuture.completedStage(null));
@@ -379,7 +374,6 @@ void shouldNotCreateCircularExceptionWhenTerminationCauseDifferentFromCursorFail
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldNotCreateCircularExceptionWhenTerminatedWithoutFailure() {
         var connection = connectionMock();
         given(connection.close()).willReturn(CompletableFuture.completedStage(null));
@@ -405,7 +399,6 @@ void shouldNotCreateCircularExceptionWhenTerminatedWithoutFailure() {
     }
 
     @Test
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldReleaseConnectionWhenTerminatedAndRolledBack() {
         var connection = connectionMock();
         given(connection.close()).willReturn(CompletableFuture.completedStage(null));
@@ -875,7 +868,6 @@ private ResultCursorsHolder mockResultCursorWith(ClientException clientException
         return resultCursorsHolder;
     }
 
-    @SuppressWarnings("ThrowableNotThrown")
     private Supplier<CompletionStage<Void>> mapTransactionAction(String actionName, UnmanagedTransaction tx) {
         Supplier<CompletionStage<Void>> action;
         if ("commit".equals(actionName)) {

driver/src/test/java/org/neo4j/driver/internal/reactive/InternalRxTransactionTest.java

@@ -109,7 +109,6 @@ void shouldDelegateRun(Function<RxTransaction, RxResult> runReturnOne) {
 
     @ParameterizedTest
     @MethodSource("allTxRunMethods")
-    @SuppressWarnings("ThrowableNotThrown")
     void shouldMarkTxIfFailedToRun(Function<RxTransaction, RxResult> runReturnOne) {
         // Given
         Throwable error = new RuntimeException("Hi there");