Skip to content

Commit 06c833c

Browse files
authored
Add supported protocol versions to testkit backend (#1056)
1 parent 87b5ca5 commit 06c833c

File tree

2 files changed

+8
-15
lines changed

2 files changed

+8
-15
lines changed

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/GetFeatures.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,25 +36,31 @@
3636
public class GetFeatures implements TestkitRequest
3737
{
3838
private static final Set<String> COMMON_FEATURES = new HashSet<>( Arrays.asList(
39+
"Feature:Bolt:4.0",
40+
"Feature:Bolt:4.1",
41+
"Feature:Bolt:4.2",
42+
"Feature:Bolt:4.3",
43+
"Feature:Bolt:4.4",
3944
"AuthorizationExpiredTreatment",
4045
"ConfHint:connection.recv_timeout_seconds",
4146
"Temporary:DriverFetchSize",
4247
"Temporary:DriverMaxTxRetryTime",
4348
"Feature:Auth:Bearer",
4449
"Feature:Auth:Kerberos",
4550
"Feature:Auth:Custom",
46-
"Feature:Bolt:4.4",
4751
"Feature:Impersonation",
4852
"Temporary:FastFailingDiscovery"
4953
) );
5054

5155
private static final Set<String> SYNC_FEATURES = new HashSet<>( Arrays.asList(
56+
"Feature:Bolt:3.0",
5257
"Optimization:PullPipelining",
5358
"Temporary:TransactionClose",
5459
"Temporary:ResultList"
5560
) );
5661

5762
private static final Set<String> ASYNC_FEATURES = new HashSet<>( Arrays.asList(
63+
"Feature:Bolt:3.0",
5864
"Optimization:PullPipelining",
5965
"Temporary:ResultList"
6066
) );

testkit-backend/src/main/java/neo4j/org/testkit/backend/messages/requests/StartTest.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -42,21 +42,8 @@ public class StartTest implements TestkitRequest
4242
{
4343
ASYNC_SKIP_PATTERN_TO_REASON.put( "^.*\\.test_should_reject_server_using_verify_connectivity_bolt_3x0$", "Does not error as expected" );
4444

45-
// V3 tests
46-
String skipMessage = "v3 is not applicable to reactive";
47-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestAuthorizationV3\\..*$", skipMessage );
48-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestBookmarksV3\\..*$", skipMessage );
49-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.NoRoutingV3\\..*$", skipMessage );
50-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.RoutingV3\\..*$", skipMessage );
51-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestProtocolVersions\\.test_should_reject_server_using_verify_connectivity_bolt_3x0$", skipMessage );
52-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestProtocolVersions\\.test_supports_bolt_3x0", skipMessage );
53-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestIterationSessionRun\\.test_all_v3$", skipMessage );
54-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestIterationSessionRun\\.test_discards_on_session_close$", skipMessage );
55-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestIterationTxRun\\.test_batch_v3$", skipMessage );
56-
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestIterationTxRun\\.test_all_v3$", skipMessage );
57-
5845
// Current limitations (require further investigation or bug fixing)
59-
skipMessage = "Does not report RUN FAILURE";
46+
String skipMessage = "Does not report RUN FAILURE";
6047
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.Routing[^.]+\\.test_should_write_successfully_on_leader_switch_using_tx_function$", skipMessage );
6148
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestDisconnects\\.test_disconnect_after_hello$", skipMessage );
6249
REACTIVE_SKIP_PATTERN_TO_REASON.put( "^.*\\.TestDisconnects\\.test_disconnect_session_on_run$", skipMessage );

0 commit comments

Comments
 (0)