Skip to content

Commit 027cb90

Browse files
authored
Suppress resource warnings in existing tests (#1459)
1 parent 6f8af77 commit 027cb90

38 files changed

+164
-11
lines changed

driver/src/test/java/org/neo4j/driver/ParametersTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ void shouldGiveHelpfulMessageOnMisalignedInput(Object obj, String expectedMsg) {
7373

7474
@ParameterizedTest
7575
@MethodSource("addressesToParse")
76+
@SuppressWarnings("resource")
7677
void shouldNotBePossibleToUseInvalidParameterTypesViaParameters(Object obj, String expectedMsg) {
7778
var session = mockedSession();
7879
var e = assertThrows(ClientException.class, () -> session.run("RETURN {a}", parameters("a", obj)));
@@ -81,6 +82,7 @@ void shouldNotBePossibleToUseInvalidParameterTypesViaParameters(Object obj, Stri
8182

8283
@ParameterizedTest
8384
@MethodSource("addressesToParse")
85+
@SuppressWarnings("resource")
8486
void shouldNotBePossibleToUseInvalidParametersViaMap(Object obj, String expectedMsg) {
8587
var session = mockedSession();
8688
var e = assertThrows(ClientException.class, () -> session.run("RETURN {a}", singletonMap("a", obj)));
@@ -89,6 +91,7 @@ void shouldNotBePossibleToUseInvalidParametersViaMap(Object obj, String expected
8991

9092
@ParameterizedTest
9193
@MethodSource("addressesToParse")
94+
@SuppressWarnings("resource")
9295
void shouldNotBePossibleToUseInvalidParametersViaRecord(Object obj, String expectedMsg) {
9396
assumeTrue(obj instanceof Value);
9497
Record record = new InternalRecord(singletonList("a"), new Value[] {(Value) obj});

driver/src/test/java/org/neo4j/driver/integration/ChannelConnectorImplIT.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ void shouldFailWhenTLSHandshakeTakesTooLong() throws Exception {
166166
}
167167

168168
@Test
169+
@SuppressWarnings("resource")
169170
void shouldThrowServiceUnavailableExceptionOnFailureDuringConnect() throws Exception {
170171
var server = new ServerSocket(0);
171172
var address = new BoltServerAddress("localhost", server.getLocalPort());

driver/src/test/java/org/neo4j/driver/integration/QueryRunnerCloseIT.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ void tearDown() {
5151
}
5252

5353
@Test
54+
@SuppressWarnings("resource")
5455
void shouldErrorToAccessRecordsAfterConsume() {
5556
// Given
5657
var result = neo4j.driver().session().run("UNWIND [1,2] AS a RETURN a");
@@ -70,6 +71,7 @@ void shouldErrorToAccessRecordsAfterConsume() {
7071
}
7172

7273
@Test
74+
@SuppressWarnings("resource")
7375
void shouldErrorToAccessRecordsAfterClose() {
7476
// Given
7577
var session = neo4j.driver().session();
@@ -90,6 +92,7 @@ void shouldErrorToAccessRecordsAfterClose() {
9092
}
9193

9294
@Test
95+
@SuppressWarnings("resource")
9396
void shouldAllowConsumeAndKeysAfterConsume() {
9497
// Given
9598
var result = neo4j.driver().session().run("UNWIND [1,2] AS a RETURN a");
@@ -107,6 +110,7 @@ void shouldAllowConsumeAndKeysAfterConsume() {
107110
}
108111

109112
@Test
113+
@SuppressWarnings("resource")
110114
void shouldAllowSummaryAndKeysAfterClose() {
111115
// Given
112116
var session = neo4j.driver().session();
@@ -126,6 +130,7 @@ void shouldAllowSummaryAndKeysAfterClose() {
126130
}
127131

128132
@Test
133+
@SuppressWarnings("resource")
129134
void shouldErrorToAccessRecordsAfterConsumeAsync() {
130135
// Given
131136
var session = neo4j.driver().session(AsyncSession.class);
@@ -144,6 +149,7 @@ void shouldErrorToAccessRecordsAfterConsumeAsync() {
144149
}
145150

146151
@Test
152+
@SuppressWarnings("resource")
147153
void shouldErrorToAccessRecordsAfterCloseAsync() {
148154
// Given
149155
var session = neo4j.driver().session(AsyncSession.class);
@@ -162,6 +168,7 @@ void shouldErrorToAccessRecordsAfterCloseAsync() {
162168
}
163169

164170
@Test
171+
@SuppressWarnings("resource")
165172
void shouldAllowConsumeAndKeysAfterConsumeAsync() {
166173
// Given
167174
var session = neo4j.driver().session(AsyncSession.class);
@@ -181,6 +188,7 @@ void shouldAllowConsumeAndKeysAfterConsumeAsync() {
181188
}
182189

183190
@Test
191+
@SuppressWarnings("resource")
184192
void shouldAllowConsumeAndKeysAfterCloseAsync() {
185193
// Given
186194
var session = neo4j.driver().session(AsyncSession.class);

driver/src/test/java/org/neo4j/driver/integration/SessionBoltV3IT.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ void beforeAll() {
7373
}
7474

7575
@Test
76+
@SuppressWarnings("resource")
7677
void shouldSetTransactionMetadata() {
7778
Map<String, Object> metadata = new HashMap<>();
7879
metadata.put("a", "hello world");
@@ -104,6 +105,7 @@ void shouldSetTransactionMetadataAsync() {
104105
}
105106

106107
@Test
108+
@SuppressWarnings("resource")
107109
void shouldSetTransactionTimeout() {
108110
// create a dummy node
109111
var session = driver.session();
@@ -128,6 +130,7 @@ void shouldSetTransactionTimeout() {
128130
}
129131

130132
@Test
133+
@SuppressWarnings("resource")
131134
void shouldSetTransactionTimeoutAsync() {
132135
// create a dummy node
133136
var asyncSession = driver.asyncSession();

0 commit comments

Comments
 (0)