Skip to content

Commit 9d5ae8e

Browse files
webknjaznedbat
authored andcommitted
test: add regression test for path w/ trailing wildcard
We decided to leave trailing `*` meaning the same as `**` because it was already in use. Original description: This patch demonstrates a corner case in the path glob matcher. Specifically, it documents how a single trailing asterisk is supposed to be treated as opposed to a double asterisk. With [[1]], a trailing `/*` is interpreted as an equivalent of `/**`. The commit add a case that shows that `/*` shouldn't be greedy as described in the docs [[2]][[3]]. See also the observations in the bug report ticket [[4]]. [1]: ec6205a [2]: https://coverage.rtfd.io/en/stable/source.html#file-patterns [3]: https://coverage.rtfd.io/en/7.2.7/migrating.html#migrating-to-coverage-py-7-x [4]: #1407 (comment)
1 parent f0c18f6 commit 9d5ae8e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tests/test_files.py

+1
Original file line numberDiff line numberDiff line change
@@ -348,6 +348,7 @@ def test_glob_matcher(self) -> None:
348348
(self.make_file("sub/file1.py"), True),
349349
(self.make_file("sub/file2.c"), False),
350350
(self.make_file("sub2/file3.h"), True),
351+
(self.make_file("sub2/sub/file3.h"), True),
351352
(self.make_file("sub3/file4.py"), True),
352353
(self.make_file("sub3/file5.c"), False),
353354
]

0 commit comments

Comments
 (0)