Skip to content

Commit 51f395d

Browse files
committed
test: stricter regex to avoid false CodeQL alarms
Will fix: https://github.com/nedbat/coveragepy/security/code-scanning/3 https://github.com/nedbat/coveragepy/security/code-scanning/4 (though tbh, not sure how to close those as fixed?)
1 parent 545d8bc commit 51f395d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

tests/test_html.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -663,8 +663,8 @@ def compare_html(
663663
"""Specialized compare function for our HTML files."""
664664
__tracebackhide__ = True # pytest, please don't show me this function.
665665
scrubs = [
666-
(r'/coverage.readthedocs.io/?[-.\w/]*', '/coverage.readthedocs.io/VER'),
667-
(r'coverage.py v[\d.abcdev]+', 'coverage.py vVER'),
666+
(r'/coverage\.readthedocs\.io/?[-.\w/]*', '/coverage.readthedocs.io/VER'),
667+
(r'coverage\.py v[\d.abcdev]+', 'coverage.py vVER'),
668668
(r'created at \d\d\d\d-\d\d-\d\d \d\d:\d\d [-+]\d\d\d\d', 'created at DATE'),
669669
(r'created at \d\d\d\d-\d\d-\d\d \d\d:\d\d', 'created at DATE'),
670670
# Occasionally an absolute path is in the HTML report.

tests/test_xml.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -465,7 +465,7 @@ def compare_xml(expected: str, actual: str, actual_extra: bool = False) -> None:
465465
(r' timestamp="\d+"', ' timestamp="TIMESTAMP"'),
466466
(r' version="[-.\w]+"', ' version="VERSION"'),
467467
(r'<source>\s*.*?\s*</source>', '<source>%s</source>' % re.escape(source_path)),
468-
(r'/coverage.readthedocs.io/?[-.\w/]*', '/coverage.readthedocs.io/VER'),
468+
(r'/coverage\.readthedocs\.io/?[-.\w/]*', '/coverage.readthedocs.io/VER'),
469469
]
470470
compare(expected, actual, scrubs=scrubs, actual_extra=actual_extra)
471471

0 commit comments

Comments
 (0)