fix: don't forbid plus signs in file names. #1513

Author: nedbat

CHANGES.rst

@@ -20,9 +20,13 @@ development at the same time, such as 4.5.x and 5.0.
 Unreleased
 ----------
 
+- File pattern rules were too strict, forbidding plus signs and curly braces in
+  directory and file names.  This is now fixed, closing `issue 1513`_.
+
 - The PyPy wheel now installs on PyPy 3.7, 3.8, and 3.9, closing `issue 1510`_.
 
 .. _issue 1510: https://github.com/nedbat/coveragepy/issues/1510
+.. _issue 1513: https://github.com/nedbat/coveragepy/issues/1513
 
 
 .. _changes_7-0-0:

coverage/files.py

@@ -325,7 +325,7 @@ def sep(s):
     (r"\?", r"[^/\\\\]"),           # ? matches one non slash-like
     (r"\[.*?\]", r"\g<0>"),         # [a-f] matches [a-f]
     (r"[a-zA-Z0-9_-]+", r"\g<0>"),  # word chars match themselves
-    (r"[\[\]+{}]", None),           # Can't have regex special chars
+    (r"[\[\]]", None),              # Can't have single square brackets
     (r".", r"\\\g<0>"),             # Anything else is escaped to be safe
 ]]
 

tests/test_files.py

@@ -230,10 +230,18 @@ def globs_to_regex_params(
             matches=["foo", "hello/foo", "hi/there/foo"],
             nomatches=["foob", "hello/foob", "hello/Foo"],
         ),
+        globs_to_regex_params(
+            ["a+b/foo*", "x{y}z/foo*"],
+            matches=["a+b/foo", "a+b/foobar", "x{y}z/foobar"],
+            nomatches=["aab/foo", "ab/foo", "xyz/foo"],
+        ),
     ]))
 )
 def test_globs_to_regex(patterns, case_insensitive, partial, text, result):
     regex = globs_to_regex(patterns, case_insensitive=case_insensitive, partial=partial)
+    print(patterns)
+    print(regex)
+    print(text)
     assert bool(regex.match(text)) == result
 
 
@@ -243,8 +251,6 @@ def test_globs_to_regex(patterns, case_insensitive, partial, text, result):
     ("*****/foo.py", "*****"),
     ("Hello]there", "]"),
     ("Hello[there", "["),
-    ("Hello+there", "+"),
-    ("{a,b}c", "{"),
     ("x/a**/b.py", "a**"),
     ("x/abcd**/b.py", "abcd**"),
     ("x/**a/b.py", "**a"),