Merge PR #164 from nblockchain/wip/upgradeCI

* CI: upgrade checkout action.
* CI: remove old git workaround.
* CI: update to ubuntu 23.10 (simpler npm install).

Author: knocte

.github/workflows/CI.yml

@@ -12,19 +12,17 @@ on:
 jobs:
   build-fs:
     name: Build F#
+    # TODO: upgrade to 24.04->24.04 (because LTS) as soon as it's available, instead of 22.04->23.10
     runs-on: ubuntu-22.04
     container:
-      image: "ubuntu:22.04"
+      image: "ubuntu:23.10"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Install required dependencies
         run: |
           apt update
           apt install --yes sudo
           sudo apt install --yes --no-install-recommends git
-      # workaround for https://github.com/actions/runner/issues/2033
-      - name: ownership workaround
-        run: git config --global --add safe.directory '*'
 
       - name: Setup .NET
         run: |
@@ -44,11 +42,12 @@ jobs:
   file-conventions-tests:
     name: Run FileConventions-lib unit tests
     needs: build-fs
+    # TODO: upgrade to 24.04->24.04 (because LTS) as soon as it's available, instead of 22.04->23.10
     runs-on: ubuntu-22.04
     container:
-      image: "ubuntu:22.04"
+      image: "ubuntu:23.10"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Install required dependencies
         run: |
           apt update
@@ -69,22 +68,20 @@ jobs:
 
   build-ts:
     name: Build TypeScript
+
+    # TODO: upgrade to 24.04->24.04 (because LTS) as soon as it's available, instead of 22.04->23.10
     runs-on: ubuntu-22.04
     container:
-      image: "ubuntu:22.04"
+      image: "ubuntu:23.10"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Install required dependencies
         run: |
           apt update
           apt install --yes sudo
           sudo apt install --yes --no-install-recommends git ca-certificates
 
           sudo apt install --yes --no-install-recommends npm curl
-          # need to update nodejs because with ubuntu's default nodejs version we would get this error:
-          # error @jest/[email protected]: The engine "node" is incompatible with this module. Expected version "^14.15.0 || ^16.10.0 || >=18.0.0". Got "12.22.9"
-          sudo npm install --global n
-          sudo n lts
       - name: Print versions
         run: |
           git --version
@@ -110,22 +107,19 @@ jobs:
   commitlint-plugins-tests:
     name: Run commitlint-related tests
     needs: build-ts
+    # TODO: upgrade to 24.04->24.04 (because LTS) as soon as it's available, instead of 22.04->23.10
     runs-on: ubuntu-22.04
     container:
-      image: "ubuntu:22.04"
+      image: "ubuntu:23.10"
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Install required dependencies
         run: |
           apt update
           apt install --yes sudo
           sudo apt install --yes --no-install-recommends git ca-certificates
 
           sudo apt install --yes --no-install-recommends npm curl
-          # need to update nodejs because with ubuntu's default nodejs version we would get this error:
-          # error @jest/[email protected]: The engine "node" is incompatible with this module. Expected version "^14.15.0 || ^16.10.0 || >=18.0.0". Got "12.22.9"
-          sudo npm install --global n
-          sudo n lts
       - name: Install commitlint
         run: |
           npm install conventional-changelog-conventionalcommits
@@ -152,39 +146,27 @@ jobs:
     needs:
       - file-conventions-tests
       - commitlint-plugins-tests
+    # TODO: upgrade to 24.04->24.04 (because LTS) as soon as it's available, instead of 22.04->23.10
     runs-on: ubuntu-22.04
     container:
-      image: "ubuntu:22.04"
+      image: "ubuntu:23.10"
     env:
       GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
     steps:
       - name: Install required dependencies
         run: |
           apt update && apt install --yes sudo
-          sudo apt install --yes --no-install-recommends git
 
           sudo apt install --yes --no-install-recommends npm curl
-          # need to update nodejs because with ubuntu's default nodejs version we would get this error:
-          # ```
-          # + npx commitlint --from HEAD~1 --to HEAD --verbose
-          # /__w/conventions/conventions/node_modules/typescript/lib/typescript.js:139
-          #    for (let i = startIndex ?? 0; i < array.length; i++) {
-          #                            ^
-          #
-          # SyntaxError: Unexpected token '?'
-          #    at wrapSafe (internal/modules/cjs/loader.js:915:16)
-          # ...
-          # ```
-          sudo npm install --global n
-          sudo n lts
-      - uses: actions/checkout@v2
+
+          sudo apt install --yes --no-install-recommends git
+          # workaround for https://github.com/actions/runner/issues/2033
+          git config --global --add safe.directory '*'
+      - uses: actions/checkout@v4
         with:
           submodules: recursive
           # needed because of commit-lint, see https://github.com/conventional-changelog/commitlint/issues/3376
           fetch-depth: 0
-      # workaround for https://github.com/actions/runner/issues/2033
-      - name: ownership workaround
-        run: git config --global --add safe.directory '*'
       - name: Print versions
         run: |
           git --version