Skip to content

Implicitly set an id to the Navigator frame #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rigor789 opened this issue Mar 4, 2020 · 1 comment
Closed

Implicitly set an id to the Navigator frame #27

rigor789 opened this issue Mar 4, 2020 · 1 comment
Labels

Comments

@rigor789
Copy link
Member

rigor789 commented Mar 4, 2020

When creating a Navigator frame, we should implicitly set an id and not use the default one.

The issue is when you have multiple frames, you might run into a situation where both the Navigator and your Frame will try to use the same ID.

In NativeScript-Vue 2.5.0 we removed the frame-id collision handling, as it was causing another set of issues (nativescript-vue/nativescript-vue#532), causing the last created Frame instance with a given id to overwrite the previous one in the Frame lookup table causing unexpected navigation behaviour.

The fix is simple, we can add a new id property with a default value of navigatorFrame for instance, and refactor all calls to $navigateTo and $navigateBack to include this id as a navigation option.

@github-actions
Copy link

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant