Merge pull request #150 from kmmccafferty96/master

farfromrefug · web-flow · commit a4677e41afa6 · 2020-06-20T10:27:05.000+02:00
fix(bottomsheet): support Angular Ivy compiler
diff --git a/package.json b/package.json
@@ -56,6 +56,7 @@
         "@commitlint/config-conventional": "^8.3.4",
         "@nativescript/angular":"8.21.0",
         "@nativescript/core":"6.5.1",
+        "@types/node": "14.0.4",
         "husky": "^4.2.3",
         "lerna": "^3.20.2",
         "nativescript-vue": "2.5.1",
diff --git a/src/bottomsheet/angular/bottomsheet.service.ts b/src/bottomsheet/angular/bottomsheet.service.ts
@@ -121,7 +121,7 @@ export class BottomSheetService {
         const detachedLoaderFactory = factoryResolver.resolveComponentFactory(DetachedLoader);
         const childInjector = this.createChildInjector(bottomSheetParams, viewContainerRef);
 
-        return viewContainerRef.createComponent(detachedLoaderFactory, -1, childInjector, null);
+        return viewContainerRef.createComponent(detachedLoaderFactory, 0, childInjector, null);
     }
 
     private async loadComponent(type: Type<any>): Promise<ViewWithBottomSheetBase> {

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ export class BottomSheetService {`
`121`	`121`	`const detachedLoaderFactory = factoryResolver.resolveComponentFactory(DetachedLoader);`
`122`	`122`	`const childInjector = this.createChildInjector(bottomSheetParams, viewContainerRef);`
`123`	`123`
`124`		`- return viewContainerRef.createComponent(detachedLoaderFactory, -1, childInjector, null);`
	`124`	`+ return viewContainerRef.createComponent(detachedLoaderFactory, 0, childInjector, null);`
`125`	`125`	`}`
`126`	`126`
`127`	`127`	`private async loadComponent(type: Type<any>): Promise<ViewWithBottomSheetBase> {`