Merge pull request #139 from james-criscuolo/master

farfromrefug · web-flow · commit 3b2989f532ce · 2020-04-29T16:32:46.000+02:00
Angular BottomNavigationBar showBadge fix
diff --git a/src/bottomnavigationbar/bottomnavigationbar.android.ts b/src/bottomnavigationbar/bottomnavigationbar.android.ts
@@ -132,7 +132,7 @@ export class BottomNavigationBar extends BottomNavigationBarBase {
         // showBadge method is available in v1.1.0-alpha07 of material components
         // but NS team has the .d.ts for version 1
         // that's why we need to cast the nativeView to any to avoid typing errors
-        const badge = (this.nativeViewProtected as any).showBadge(index);
+        const badge = (this.nativeViewProtected as any).getOrCreateBadge(index);
         if (value) {
             badge.setNumber(value);
         }

Original file line number	Diff line number	Diff line change
`@@ -132,7 +132,7 @@ export class BottomNavigationBar extends BottomNavigationBarBase {`
`132`	`132`	`// showBadge method is available in v1.1.0-alpha07 of material components`
`133`	`133`	`// but NS team has the .d.ts for version 1`
`134`	`134`	`// that's why we need to cast the nativeView to any to avoid typing errors`
`135`		`- const badge = (this.nativeViewProtected as any).showBadge(index);`
	`135`	`+ const badge = (this.nativeViewProtected as any).getOrCreateBadge(index);`
`136`	`136`	`if (value) {`
`137`	`137`	`badge.setNumber(value);`
`138`	`138`	`}`