Skip to content

Commit 9357f6a

Browse files
committed
fix: set correct source map path for webpack
Currently source map path for webpack is set to `src` which is not correct for js projects and in case when the user changes appDirPath property in `nsconfig` file.
1 parent 3d1f5eb commit 9357f6a

File tree

2 files changed

+18
-32
lines changed

2 files changed

+18
-32
lines changed

package.json

+8-32
Original file line numberDiff line numberDiff line change
@@ -140,10 +140,7 @@
140140
"platform": "ios",
141141
"appRoot": "${workspaceRoot}",
142142
"sourceMaps": true,
143-
"watch": true,
144-
"sourceMapPathOverrides": {
145-
"webpack:///*": "${workspaceRoot}/src/*"
146-
}
143+
"watch": true
147144
},
148145
{
149146
"name": "Attach on iOS",
@@ -152,10 +149,7 @@
152149
"platform": "ios",
153150
"appRoot": "${workspaceRoot}",
154151
"sourceMaps": true,
155-
"watch": false,
156-
"sourceMapPathOverrides": {
157-
"webpack:///*": "${workspaceRoot}/src/*"
158-
}
152+
"watch": false
159153
},
160154
{
161155
"name": "Launch on Android",
@@ -164,10 +158,7 @@
164158
"platform": "android",
165159
"appRoot": "${workspaceRoot}",
166160
"sourceMaps": true,
167-
"watch": true,
168-
"sourceMapPathOverrides": {
169-
"webpack:///*": "${workspaceRoot}/src/*"
170-
}
161+
"watch": true
171162
},
172163
{
173164
"name": "Attach on Android",
@@ -176,10 +167,7 @@
176167
"platform": "android",
177168
"appRoot": "${workspaceRoot}",
178169
"sourceMaps": true,
179-
"watch": false,
180-
"sourceMapPathOverrides": {
181-
"webpack:///*": "${workspaceRoot}/src/*"
182-
}
170+
"watch": false
183171
}
184172
],
185173
"configurationSnippets": [
@@ -193,10 +181,7 @@
193181
"platform": "ios",
194182
"appRoot": "^\"\\${workspaceRoot}\"",
195183
"sourceMaps": true,
196-
"watch": true,
197-
"sourceMapPathOverrides": {
198-
"webpack:///*": "${workspaceRoot}/src/*"
199-
}
184+
"watch": true
200185
}
201186
},
202187
{
@@ -209,10 +194,7 @@
209194
"platform": "android",
210195
"appRoot": "^\"\\${workspaceRoot}\"",
211196
"sourceMaps": true,
212-
"watch": true,
213-
"sourceMapPathOverrides": {
214-
"webpack:///*": "${workspaceRoot}/src/*"
215-
}
197+
"watch": true
216198
}
217199
},
218200
{
@@ -225,10 +207,7 @@
225207
"platform": "ios",
226208
"appRoot": "^\"\\${workspaceRoot}\"",
227209
"sourceMaps": true,
228-
"watch": false,
229-
"sourceMapPathOverrides": {
230-
"webpack:///*": "${workspaceRoot}/src/*"
231-
}
210+
"watch": false
232211
}
233212
},
234213
{
@@ -241,10 +220,7 @@
241220
"platform": "android",
242221
"appRoot": "^\"\\${workspaceRoot}\"",
243222
"sourceMaps": true,
244-
"watch": false,
245-
"sourceMapPathOverrides": {
246-
"webpack:///*": "${workspaceRoot}/src/*"
247-
}
223+
"watch": false
248224
}
249225
}
250226
],

src/debug-adapter/nativeScriptDebugAdapter.ts

+10
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,16 @@ export class NativeScriptDebugAdapter extends ChromeDebugAdapter {
144144
args.webRoot = args.appRoot;
145145
}
146146

147+
if (!args.sourceMapPathOverrides) {
148+
args.sourceMapPathOverrides = { };
149+
}
150+
151+
if (!args.sourceMapPathOverrides['webpack:///*']) {
152+
const appDirPath = this.getAppDirPath(args.webRoot) || 'app';
153+
const fullAppDirPath = join(args.webRoot, appDirPath);
154+
args.sourceMapPathOverrides['webpack:///*'] = `${fullAppDirPath}/*`;
155+
}
156+
147157
return args;
148158
}
149159

0 commit comments

Comments
 (0)