Skip to content

Commit 1fab444

Browse files
authored
Merge pull request #107 from NativeScript/android-v8-inspector-debugger-support
Android v8 inspector debugger support
2 parents 4cbd532 + 579b351 commit 1fab444

File tree

7 files changed

+348
-178
lines changed

7 files changed

+348
-178
lines changed

package.json

+3-1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
],
2626
"license": "SEE LICENSE IN LICENSE.txt",
2727
"dependencies": {
28+
"vscode-chrome-debug-core": "3.9.1",
2829
"node-ipc": "^8.9.2",
2930
"source-map": "^0.5.3",
3031
"xmlhttprequest": "https://github.com/telerik/node-XMLHttpRequest/tarball/master",
@@ -42,7 +43,8 @@
4243
"typescript": "^2.0.6",
4344
"vsce": "^1.0.0",
4445
"vscode": "^1.0.3",
45-
"vscode-debugadapter-testsupport": "^1.7.0"
46+
"vscode-debugadapter-testsupport": "^1.7.0",
47+
"chrome-remote-debug-protocol": "git://github.com/roblourens/chrome-remote-debug-protocol.git"
4648
},
4749
"scripts": {
4850
"clean": "git clean -fdx",

src/debug-adapter/adapter/pathTransformer.ts

+7-4
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,14 @@ export class PathTransformer implements DebugProtocol.IDebugTransformer {
9696
if (!this.inferedDeviceRoot && this._platform === "android")
9797
{
9898
this.inferedDeviceRoot = utils.inferDeviceRoot(this._appRoot, this._platform, webkitUrl);
99-
Services.logger().log("\n\n\n ***Inferred device root: " + this.inferedDeviceRoot + "\n\n\n");
100-
101-
if (this.inferedDeviceRoot.indexOf("/data/user/0/") != -1)
99+
if (this.inferedDeviceRoot)
102100
{
103-
this.inferedDeviceRoot = this.inferedDeviceRoot.replace("/data/user/0/", "/data/data/");
101+
Services.logger().log("\n\n\n ***Inferred device root: " + this.inferedDeviceRoot + "\n\n\n");
102+
103+
if (this.inferedDeviceRoot.indexOf("/data/user/0/") != -1)
104+
{
105+
this.inferedDeviceRoot = this.inferedDeviceRoot.replace("/data/user/0/", "/data/data/");
106+
}
104107
}
105108
}
106109

src/debug-adapter/connection/INSDebugConnection.ts

+5
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
export interface INSDebugConnection {
2+
3+
attach(target: number | string, url?: string): Promise<void>
4+
5+
enable() : Promise<void>;
6+
27
on(eventName: string, handler: (msg: any) => void): void;
38

49
close(): void;

0 commit comments

Comments
 (0)