CLN: refactor _getitem_axis() of _iLocIndexer class

 _get_list_axis() is factored out of _getitem_axis() to handle list-like type of input.

Author: nathalier

pandas/core/indexing.py

@@ -1595,6 +1595,16 @@ def _get_slice_axis(self, slice_obj, axis=0):
         else:
             return self.obj.take(slice_obj, axis=axis, convert=False)
 
+    def _get_list_axis(self, key_list, axis=0):
+
+        # validate list bounds
+        self._is_valid_list_like(key_list, axis)
+
+        # force an actual list
+        key_list = list(key_list)
+        return self.obj.take(key_list, axis=axis, convert=False)
+
+
     def _getitem_axis(self, key, axis=0):
 
         if isinstance(key, slice):
@@ -1606,26 +1616,18 @@ def _getitem_axis(self, key, axis=0):
             return self._getbool_axis(key, axis=axis)
 
         # a single integer or a list of integers
-        else:
-
-            if is_list_like_indexer(key):
-
-                # validate list bounds
-                self._is_valid_list_like(key, axis)
-
-                # force an actual list
-                key = list(key)
-                return self.obj.take(key, axis=axis, convert=False)
+        elif is_list_like_indexer(key):
+            return self._get_list_axis(key, axis=axis)
 
-            else:
-                key = self._convert_scalar_indexer(key, axis)
+        else:
+            key = self._convert_scalar_indexer(key, axis)
 
-                if not is_integer(key):
-                    raise TypeError("Cannot index by location index with a "
-                                    "non-integer key")
+            if not is_integer(key):
+                raise TypeError("Cannot index by location index with a "
+                                "non-integer key")
 
-                # validate the location
-                self._is_valid_integer(key, axis)
+            # validate the location
+            self._is_valid_integer(key, axis)
 
             return self._get_loc(key, axis=axis)