Merge pull request topcoder-platform#4915 from topcoder-platform/issue-4910

Added !isEmpty check before call phaseStartDate and phaseEndDate

Author: luizrrodrigues

src/shared/components/challenge-listing/Tooltips/ProgressBarTooltip/index.jsx

@@ -101,13 +101,13 @@ function Tip(props) {
   const submissionPhase = allPhases.find(phase => phase.name === 'Submission') || {};
   const checkpointPhase = allPhases.find(phase => phase.name === 'Checkpoint Submission') || {};
 
-  if (registrationPhase) {
+  if (!_.isEmpty(registrationPhase)) {
     steps.push({
       date: phaseStartDate(registrationPhase),
       name: 'Start',
     });
   }
-  if (checkpointPhase) {
+  if (!_.isEmpty(checkpointPhase)) {
     steps.push({
       date: phaseEndDate(checkpointPhase),
       name: 'Checkpoint',
@@ -119,7 +119,7 @@ function Tip(props) {
       date: phaseEndDate(iterativeReviewPhase),
       name: 'Iterative Review',
     });
-  } else if (submissionPhase) {
+  } else if (!_.isEmpty(submissionPhase)) {
     steps.push({
       date: phaseEndDate(submissionPhase),
       name: 'Submission',

src/shared/utils/challenge-listing/sort.js

@@ -3,7 +3,7 @@
  */
 
 import moment from 'moment';
-import { find, sumBy } from 'lodash';
+import { find, sumBy, isEmpty } from 'lodash';
 import { phaseStartDate, phaseEndDate } from './helper';
 
 export const SORTS = {
@@ -59,7 +59,7 @@ export default {
         const registrationPhase = find(challenge.phases, p => p.name === 'Registration') || {};
         const submissionPhase = find(challenge.phases, p => p.name === 'Submission') || {};
         // registration phase exists
-        if (registrationPhase) {
+        if (!isEmpty(registrationPhase)) {
           return moment(phaseStartDate(registrationPhase));
         }
         // registration phase doesnt exist, This is possibly a F2F or TSK. Take submission phase