Fix un-catchable error from poolCluster.remove

Author: dougwilson

lib/PoolCluster.js

@@ -116,19 +116,20 @@ PoolCluster.prototype.of = function(pattern, selector) {
   return this._namespaces[key];
 };
 
-PoolCluster.prototype.remove = function(pattern) {
+PoolCluster.prototype.remove = function remove(pattern) {
   var foundNodeIds = this._findNodeIds(pattern);
 
   for (var i = 0; i < foundNodeIds.length; i++) {
     var node = this._getNode(foundNodeIds[i]);
     var index = this._serviceableNodeIds.indexOf(node.id);
+
     if (index !== -1) {
       this._serviceableNodeIds.splice(index, 1);
       delete this._nodes[node.id];
 
       this._clearFindCaches();
 
-      node.pool.end();
+      node.pool.end(_noop);
     }
   }
 };

test/unit/pool-cluster/test-remove-by-name.js

@@ -33,7 +33,10 @@ server.listen(common.fakeServerPort, function (err) {
         cluster.remove('SLAVE1');
         cluster.remove('SLAVE2');
 
-        server._server.close();
+        cluster.end(function (err) {
+          assert.ifError(err);
+          server.destroy();
+        });
       });
     });
   });

test/unit/pool-cluster/test-remove-by-pattern.js

@@ -25,7 +25,10 @@ server.listen(common.fakeServerPort, function (err) {
 
       cluster.remove('SLAVE*');
 
-      server._server.close();
+        cluster.end(function (err) {
+          assert.ifError(err);
+          server.destroy();
+        });
     });
   });
 });

test/unit/pool-cluster/test-remove-fatal-end.js

@@ -0,0 +1,25 @@
+var assert  = require('assert');
+var common  = require('../../common');
+var cluster = common.createPoolCluster();
+var server  = common.createFakeServer();
+
+var poolConfig = common.getTestConfig({port: common.fakeServerPort});
+cluster.add('SLAVE1', poolConfig);
+cluster.add('SLAVE2', poolConfig);
+
+server.listen(common.fakeServerPort, function (err) {
+  assert.ifError(err);
+
+  var pool = cluster.of('SLAVE*', 'ORDER');
+
+  pool.getConnection(function (err, connection) {
+    assert.ifError(err);
+    assert.strictEqual(connection._clusterId, 'SLAVE1');
+
+    connection.release();
+    server.destroy();
+    cluster.remove('SLAVE*');
+
+    cluster.end(assert.ifError);
+  });
+});