Clone connection config for new pool connections

fixes #805

Author: dougwilson

Changes.md

@@ -6,6 +6,7 @@ you spot any mistakes.
 
 ## HEAD
 
+* Clone connection config for new pool connections
 * Default `connectTimeout` to 2 minutes
 
 ## v2.2.0 (2014-04-27)

lib/Pool.js

@@ -35,7 +35,7 @@ Pool.prototype.getConnection = function (cb) {
   }
 
   if (this.config.connectionLimit === 0 || this._allConnections.length < this.config.connectionLimit) {
-    connection = new PoolConnection(this, { config: this.config.connectionConfig });
+    connection = new PoolConnection(this, { config: this.config.newConnectionConfig() });
 
     this._allConnections.push(connection);
 

lib/PoolConfig.js

@@ -14,3 +14,12 @@ function PoolConfig(options) {
     ? 0
     : Number(options.queueLimit);
 }
+
+PoolConfig.prototype.newConnectionConfig = function newConnectionConfig() {
+  var connectionConfig = new ConnectionConfig(this.connectionConfig);
+
+  connectionConfig.clientFlags   = this.connectionConfig.clientFlags;
+  connectionConfig.maxPacketSize = this.connectionConfig.maxPacketSize;
+
+  return connectionConfig;
+};

lib/protocol/packets/ComChangeUserPacket.js

@@ -10,6 +10,7 @@ function ComChangeUserPacket(options) {
 }
 
 ComChangeUserPacket.prototype.parse = function(parser) {
+  this.command       = parser.parseUnsignedNumber(1);
   this.user          = parser.parseNullTerminatedString();
   this.scrambleBuff  = parser.parseLengthCodedBuffer();
   this.database      = parser.parseNullTerminatedString();

test/FakeServer.js

@@ -135,6 +135,20 @@ FakeConnection.prototype._parsePacket = function(header) {
       this._sendPacket(new Packets.OkPacket());
       this._parser.resetPacketNumber();
       break;
+    case Packets.ComChangeUserPacket:
+      this._clientAuthenticationPacket = new Packets.ClientAuthenticationPacket({
+        clientFlags  : this._clientAuthenticationPacket.clientFlags,
+        filler       : this._clientAuthenticationPacket.filler,
+        maxPacketSize: this._clientAuthenticationPacket.maxPacketSize,
+        protocol41   : this._clientAuthenticationPacket.protocol41,
+        charsetNumber: packet.charsetNumber,
+        database     : packet.database,
+        scrambleBuff : packet.scrambleBuff,
+        user         : packet.user
+      });
+      this._sendPacket(new Packets.OkPacket());
+      this._parser.resetPacketNumber();
+      break;
     case Packets.ComQuitPacket:
       this.emit('quit', packet);
       this._socket.end();
@@ -156,6 +170,7 @@ FakeConnection.prototype._determinePacket = function() {
     case 0x01: return Packets.ComQuitPacket;
     case 0x03: return Packets.ComQueryPacket;
     case 0x0e: return Packets.ComPingPacket;
+    case 0x11: return Packets.ComChangeUserPacket;
     default:
       throw new Error('Unknown packet, first byte: ' + firstByte);
       break;

test/unit/pool/test-change-user-config.js

@@ -0,0 +1,32 @@
+var assert = require('assert');
+var common = require('../../common');
+var pool   = common.createPool({
+  user: 'user_1',
+  port: common.fakeServerPort
+});
+
+var server = common.createFakeServer();
+
+server.listen(common.fakeServerPort, function(err) {
+  assert.ifError(err);
+
+  assert.strictEqual(pool.config.connectionConfig.user, 'user_1');
+
+  pool.getConnection(function(err, conn) {
+    assert.ifError(err);
+    assert.strictEqual(conn.config.user, 'user_1');
+
+    conn.changeUser({user: 'user_2'}, function(err) {
+      assert.ifError(err);
+      assert.strictEqual(conn.config.user, 'user_2');
+      assert.strictEqual(pool.config.connectionConfig.user, 'user_1');
+
+      conn.destroy();
+      server.destroy();
+    });
+  });
+});
+
+server.on('connection', function(incomingConnection) {
+  incomingConnection.handshake();
+});