Fix poolCluster.add to throw if PoolCluster has been closed

Author: dougwilson

Changes.md

@@ -8,6 +8,7 @@ you spot any mistakes.
 
 * Add `poolCluster.remove` to remove pools from the cluster #1006 #1007
 * Add optional callback to `poolCluster.end`
+* Fix `poolCluster.add` to throw if `PoolCluster` has been closed
 * Fix un-catchable error from `PoolCluster` when MySQL server offline #1033
 * Improve speed formatting SQL #1019
 * Support io.js

lib/PoolCluster.js

@@ -28,6 +28,29 @@ function PoolCluster(config) {
 
 Util.inherits(PoolCluster, EventEmitter);
 
+PoolCluster.prototype.add = function add(id, config) {
+  if (this._closed) {
+    throw new Error('PoolCluster is closed.');
+  }
+
+  if (typeof id === 'object') {
+    config = id;
+    id = 'CLUSTER::' + (++this._lastId);
+  }
+
+  if (typeof this._nodes[id] === 'undefined') {
+    this._nodes[id] = {
+      id: id,
+      errorCount: 0,
+      pool: new Pool({config: new PoolConfig(config)})
+    };
+
+    this._serviceableNodeIds.push(id);
+
+    this._clearFindCaches();
+  }
+};
+
 PoolCluster.prototype.end = function end(callback) {
   var cb = callback !== undefined
     ? callback
@@ -88,25 +111,6 @@ PoolCluster.prototype.of = function(pattern, selector) {
   return this._namespaces[key];
 };
 
-PoolCluster.prototype.add = function(id, config) {
-  if (typeof id === 'object') {
-    config = id;
-    id = 'CLUSTER::' + (++this._lastId);
-  }
-
-  if (typeof this._nodes[id] === 'undefined') {
-    this._nodes[id] = {
-      id: id,
-      errorCount: 0,
-      pool: new Pool({config: new PoolConfig(config)})
-    };
-
-    this._serviceableNodeIds.push(id);
-
-    this._clearFindCaches();
-  }
-};
-
 PoolCluster.prototype.remove = function(pattern) {
   var foundNodeIds = this._findNodeIds(pattern);
 

test/unit/pool-cluster/test-add-after-end.js

@@ -0,0 +1,14 @@
+var assert     = require('assert');
+var common     = require('../../common');
+var cluster    = common.createPoolCluster();
+var poolConfig = common.getTestConfig();
+
+assert.doesNotThrow(cluster.add.bind(cluster, 'SLAVE1', poolConfig));
+
+cluster.end(function (err) {
+  assert.ifError(err);
+
+  assert.throws(cluster.add.bind(cluster, 'SLAVE3', poolConfig), /PoolCluster is closed/);
+});
+
+assert.throws(cluster.add.bind(cluster, 'SLAVE2', poolConfig), /PoolCluster is closed/);