Skip to content

Commit dc23690

Browse files
committed
Fix retrieving local dates
1 parent 0e6cb10 commit dc23690

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

lib/protocol/packets/RowDataPacket.js

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -56,17 +56,18 @@ RowDataPacket.prototype._typeCast = function(field, parser, timeZone, supportBig
5656
return null;
5757
}
5858

59-
if (timeZone != 'local') {
60-
if (field.type === Types.DATE) {
61-
dateString += ' 00:00:00 ' + timeZone;
62-
} else {
63-
dateString += ' ' + timeZone;
64-
}
59+
var originalString = dateString;
60+
if (field.type === Types.DATE) {
61+
dateString += ' 00:00:00';
62+
}
63+
64+
if (timeZone !== 'local') {
65+
dateString += ' ' + timeZone;
6566
}
6667

6768
dt = new Date(dateString);
6869
if (isNaN(dt.getTime())) {
69-
return dateString;
70+
return originalString;
7071
}
7172

7273
return dt;

test/integration/connection/test-type-casting.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ var tests = [
1818
{type: 'year', insert: 2012},
1919
{type: 'timestamp', insert: new Date('2012-05-12 11:00:23')},
2020
{type: 'datetime', insert: new Date('2012-05-12 12:00:23')},
21-
{type: 'date', insert: new Date('2012-05-12 00:00:00 Z')},
21+
{type: 'date', insert: new Date('2012-05-12 00:00:00')},
2222
{type: 'time', insert: '13:13:23'},
2323
{type: 'binary(4)', insert: new Buffer([0, 1, 254, 255])},
2424
{type: 'varbinary(4)', insert: new Buffer([0, 1, 254, 255])},

0 commit comments

Comments
 (0)