Fix pool.query not emitting connection errors

fixes #941

Author: dougwilson

Changes.md

@@ -4,6 +4,10 @@ This file is a manually maintained list of changes for each release. Feel free
 to add your changes here when sending pull requests. Also send corrections if
 you spot any mistakes.
 
+## HEAD
+
+* Fix `pool.query` streaming interface not emitting connection errors #941
+
 ## v2.5.2 (2014-10-10)
 
 * Fix receiving large text fields #922

lib/Pool.js

@@ -182,8 +182,8 @@ Pool.prototype.query = function (sql, values, cb) {
 
   this.getConnection(function (err, conn) {
     if (err) {
-      var cb = query._callback;
-      cb && cb(err);
+      query.on('error', function () {});
+      query.end(err);
       return;
     }
 

test/unit/pool/test-query-stream-connection-error.js

@@ -0,0 +1,21 @@
+var assert = require('assert');
+var common = require('../../common');
+var pool   = common.createPool({port: common.fakeServerPort});
+var server = common.createFakeServer();
+
+server.listen(common.fakeServerPort, function (err) {
+  assert.ifError(err);
+
+  var query = pool.query('SELECT 1');
+
+  query.on('error', function (err) {
+    assert.ok(err, 'got error');
+    assert.equal(err.code, 'ER_HOST_NOT_PRIVILEGED');
+    assert.equal(err.fatal, true);
+    server.destroy();
+  });
+});
+
+server.on('connection', function (conn) {
+  conn.deny('You suck.', common.Errors.ER_HOST_NOT_PRIVILEGED);
+});