Throw on unknown charset option

fixes #789

Author: dougwilson

Changes.md

@@ -11,6 +11,7 @@ you spot any mistakes.
 * Prevent enqueuing sequences after fatal error #400
 * Fix geometry parser for empty fields #742
 * Accept lower-case charset option
+* Throw on unknown charset option #789
 
 ## v2.1.1 (2014-03-13)
 

lib/ConnectionConfig.js

@@ -85,7 +85,13 @@ ConnectionConfig.getDefaultFlags = function(options) {
 };
 
 ConnectionConfig.getCharsetNumber = function getCharsetNumber(charset) {
-  return Charsets[charset.toUpperCase()];
+  var num = Charsets[charset.toUpperCase()];
+
+  if (num === undefined) {
+    throw new TypeError('Unknown charset \'' + charset + '\'');
+  }
+
+  return num;
 };
 
 ConnectionConfig.parseUrl = function(url) {

test/unit/test-ConnectionConfig.js

@@ -34,4 +34,20 @@ test('ConnectionConfig#Constructor', {
 
     assert.equal(config.charsetNumber, Charsets.BIG5_CHINESE_CI);
   },
+
+  'throws on unknown charset': function() {
+    var error;
+
+    try {
+      var config = new ConnectionConfig({
+        charset: 'INVALID_CHARSET',
+      });
+    } catch (err) {
+      error = err;
+    }
+
+    assert.ok(error);
+    assert.equal(error.name, 'TypeError');
+    assert.equal(error.message, 'Unknown charset \'INVALID_CHARSET\'');
+  },
 });