Allow pool configuration when given connection string

fixes #811
closes #812

Author: dougwilson

Changes.md

@@ -7,6 +7,7 @@ you spot any mistakes.
 ## HEAD
 
 * Accept MySQL charset (like `UTF8` or `UTF8MB4`) in `charset` option #808
+* Accept pool options in connection string to `mysql.createPool` #811
 * Clone connection config for new pool connections
 * Default `connectTimeout` to 2 minutes
 * Throw on unknown SSL profile name #817

Readme.md

@@ -240,9 +240,10 @@ Use pool directly.
 ```js
 var mysql = require('mysql');
 var pool  = mysql.createPool({
-  host     : 'example.org',
-  user     : 'bob',
-  password : 'secret'
+  connectionLimit : 10,
+  host            : 'example.org',
+  user            : 'bob',
+  password        : 'secret'
 });
 
 pool.query('SELECT 1 + 1 AS solution', function(err, rows, fields) {

lib/PoolConfig.js

@@ -3,6 +3,10 @@ var ConnectionConfig = require('./ConnectionConfig');
 
 module.exports = PoolConfig;
 function PoolConfig(options) {
+  if (typeof options === 'string') {
+    options = ConnectionConfig.parseUrl(options);
+  }
+
   this.connectionConfig   = new ConnectionConfig(options);
   this.waitForConnections = (options.waitForConnections === undefined)
     ? true

test/unit/test-PoolConfig.js

@@ -29,4 +29,15 @@ test('PoolConfig#Constructor', {
     assert.equal(config.connectionConfig.debug, true);
     assert.equal(config.connectionConfig.charsetNumber, Charsets.BIG5_CHINESE_CI);
   },
+
+  'connection string can configure pool': function() {
+    var url    = 'mysql://myhost:3333/mydb?connectionLimit=2';
+    var config = new PoolConfig(url);
+
+    assert.ok(config.connectionConfig);
+    assert.equal(config.connectionConfig.host, 'myhost');
+    assert.equal(config.connectionConfig.port, 3333);
+    assert.equal(config.connectionConfig.database, 'mydb');
+    assert.equal(config.connectionLimit, 2);
+  },
 });