adding support for unit testing on windows systems

modified:   Readme.md
new file:   make.bat
modified:   test/integration/connection/test-unix-domain-socket.js

Author: kai-koch

Readme.md

@@ -879,9 +879,17 @@ Set the environment variables `MYSQL_DATABASE`, `MYSQL_HOST`, `MYSQL_PORT`, `MYS
   make test
 ```
 
+## Running unit tests on windows
+
+* Edit the variables in the file ```make.bat```  according to your system and mysql-settings.
+* Make sure the database (e.g. 'test') you want to use exists and the user you entered has the proper rights to use the test database. (E.g. do not forget to execute the SQL-command ```FLUSH PRIVILEGES``` after you have created the user.)
+* In a DOS-box (or CMD-shell) in the folder of your application run ```npm install mysql --dev``` or in the mysql folder (```node_modules\mysql```), run ```npm install --dev```. (This will install additional developer-dependencies for node-mysql.)
+* Run ```npm test mysql``` in your applications folder or ```npm test``` in the mysql subfolder.
+* If you want to log the output into a file use ```npm test mysql > test.log``` or ```npm test > test.log```.
+
 ## Todo
 
 * Prepared statements
 * setTimeout() for Connection / Query
 * Support for encodings other than UTF-8 / ASCII
-* API support for transactions, similar to [php](http://www.php.net/manual/en/mysqli.quickstart.transactions.php)
+* API support for transactions, similar to [php](http://www.php.net/manual/en/mysqli.quickstart.transactions.php)

make.bat

@@ -0,0 +1,29 @@
+@ECHO OFF
+REM Simple 'make' replacement for windows-based system, 'npm test' will now find
+REM 'make.bat' and sets the MYSQL_ enviroment variables according to this file
+
+REM Edit the variables according to your system
+REM No spaces (' ') between variablenames, '=' and the values!
+
+REM Host to test with default: localhost
+SET MYSQL_HOST=localhost
+
+REM Default mysql port: 3306
+SET MYSQL_PORT=3306
+
+REM For a standard installatons of Wampp using http://www.apachefriends.org/
+REM the default login is 'root' and no password, but any user should do, change
+REM  the settings according to your installation
+SET MYSQL_USER=root
+SET MYSQL_PASSWORD=
+
+REM make sure the database you are using exists and the above user has access to
+REM it. Normally every user has access to the database 'test'
+SET MYSQL_DATABASE=test
+
+@ECHO ON
+node test/run.js
+@ECHO OFF
+ECHO **********************
+ECHO If the tests should fail, make sure you have SET the correct values for the enviroment variables in the file 'make.bat'
+ECHO **********************

test/integration/connection/test-unix-domain-socket.js

@@ -1,32 +1,48 @@
+/**
+ * If on a windows system, there are no unix sockets.
+ * So we skip this test and defaulting the asserts in the
+ * process.on('exit', [...]) function to false, when we find the
+ * enviroment variable 'windir' is set. I assume 'windir' will not be set on
+ * *nix-systems.
+ */
 var common     = require('../../common');
 var connection = common.createConnection({socketPath: common.fakeServerSocket});
 var assert     = require('assert');
 
 var server = common.createFakeServer();
 var didConnect = false;
-server.listen(common.fakeServerSocket, function(err) {
-  if (err) throw err;
+if (!process.env.windir) {
+  server.listen(common.fakeServerSocket, function(err) {
+    if (err) throw err;
 
-  connection.connect(function(err) {
+    connection.connect(function(err) {
     if (err) throw err;
 
     assert.equal(didConnect, false);
     didConnect = true;
 
     connection.destroy();
     server.destroy();
+    });
   });
-});
+}
 
 var hadConnection = false;
-server.on('connection', function(connection) {
-  connection.handshake();
+if (!process.env.windir) {
+  server.on('connection', function(connection) {
+    connection.handshake();
 
-  assert.equal(hadConnection, false);
-  hadConnection = true;
-});
+    assert.equal(hadConnection, false);
+    hadConnection = true;
+  });
+}
 
 process.on('exit', function() {
-  assert.equal(didConnect, true);
-  assert.equal(hadConnection, true);
-});
+  if (process.env.windir) {
+    assert.equal(didConnect, false);
+    assert.equal(hadConnection, false);
+  } else {
+    assert.equal(didConnect, true);
+    assert.equal(hadConnection, true);
+  }
+});