Fix "changedRows" to work on non-English servers

fixes #1819

Author: dougwilson

Changes.md

@@ -7,6 +7,7 @@ you spot any mistakes.
 ## HEAD
 
 * Add new Amazon RDS ca-central-1 certificate CA to Amazon RDS SSL profile #1809
+* Fix "changedRows" to work on non-English servers #1819
 * Fix typo in insecure auth error message
 * Support `mysql_native_password` auth switch request for Azure #1396 #1729 #1730
 * Update `bignumber.js` to 4.0.4

Readme.md

@@ -855,10 +855,6 @@ You can get the number of changed rows from an update statement.
 "changedRows" differs from "affectedRows" in that it does not count updated rows
 whose values were not changed.
 
-**Note** this value is parsed from the server message and only works with an English
-response. If your mysql server's install is in a different language, use
-[affectedRows](#getting-the-number-of-affected-rows).
-
 ```js
 connection.query('UPDATE posts SET ...', function (error, results, fields) {
   if (error) throw error;

lib/protocol/packets/OkPacket.js

@@ -1,3 +1,7 @@
+
+// Language-neutral expression to match ER_UPDATE_INFO
+var ER_UPDATE_INFO_REGEXP = /^[^:0-9]+: [0-9]+[^:0-9]+: ([0-9]+)[^:0-9]+: [0-9]+[^:0-9]*$/;
+
 module.exports = OkPacket;
 function OkPacket(options) {
   options = options || {};
@@ -22,8 +26,7 @@ OkPacket.prototype.parse = function(parser) {
   this.message      = parser.parsePacketTerminatedString();
   this.changedRows  = 0;
 
-  var m = this.message.match(/\schanged:\s*(\d+)/i);
-
+  var m = ER_UPDATE_INFO_REGEXP.exec(this.message);
   if (m !== null) {
     this.changedRows = parseInt(m[1], 10);
   }