Bug#37471922: Auto-fix clang-tidy warnings [24/n] [noclose]

Generate fixes for a number of warnings that clang-tidy can fix automatically.
This commit fixes the warning 'modernize-redundant-void-arg'.

Change example:
 - static void usage(void);
 + static void usage();

Change-Id: Iccc3f0f43b211712f0f70f151130cd191e8a999d

Author: MRajcic

client/check/mysqlcheck.cc

@@ -264,7 +264,7 @@ static struct my_option my_long_options[] = {
 
 static const char *load_default_groups[] = {"mysqlcheck", "client", nullptr};
 
-static void usage(void);
+static void usage();
 static int get_options(int *argc, char ***argv, MEM_ROOT *alloc);
 static int dbConnect(char *host, char *user);
 static void dbDisconnect(char *host);
@@ -273,7 +273,7 @@ static void safe_exit(int error);
 
 static int what_to_do = 0;
 
-static void usage(void) {
+static void usage() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2000"));
   puts(

client/mysql_config_editor.cc

@@ -83,13 +83,13 @@ static bool opt_verbose, opt_all,
     login_path_specified = false;
 
 static int execute_commands(int command);
-static int set_command(void);
-static int remove_command(void);
-static int print_command(void);
+static int set_command();
+static int remove_command();
+static int print_command();
 static void print_login_path(DYNAMIC_STRING *file_buf, const char *path_name);
 static void remove_login_path(DYNAMIC_STRING *file_buf, const char *path_name);
 static char *locate_login_path(DYNAMIC_STRING *file_buf, const char *path_name);
-static bool check_and_create_login_file(void);
+static bool check_and_create_login_file();
 static void mask_password_and_print(char *buf);
 static int reset_login_file(bool gen_key);
 
@@ -102,14 +102,14 @@ static int do_handle_options(int argc, char *argv[]);
 static void remove_options(DYNAMIC_STRING *file_buf, const char *path_name);
 static void remove_option(DYNAMIC_STRING *file_buf, const char *path_name,
                           const char *option_name);
-bool generate_login_key(void);
-static int read_login_key(void);
-static int add_header(void);
+bool generate_login_key();
+static int read_login_key();
+static int add_header();
 static void my_perror(const char *msg);
 
 static void verbose_msg(const char *fmt, ...)
     MY_ATTRIBUTE((format(printf, 1, 2)));
-static void usage_program(void);
+static void usage_program();
 static void usage_command(int command);
 extern "C" bool get_one_option(int optid, const struct my_option *opt,
                                char *argument);
@@ -494,7 +494,7 @@ static int execute_commands(int command) {
            0              Success
 */
 
-static int set_command(void) {
+static int set_command() {
   DBUG_TRACE;
 
   DYNAMIC_STRING file_buf, path_buf;
@@ -577,7 +577,7 @@ static int set_command(void) {
   return -1;
 }
 
-static int remove_command(void) {
+static int remove_command() {
   DBUG_TRACE;
 
   DYNAMIC_STRING file_buf, path_buf;
@@ -625,7 +625,7 @@ static int remove_command(void) {
            0              Success
 */
 
-static int print_command(void) {
+static int print_command() {
   DBUG_TRACE;
   DYNAMIC_STRING file_buf;
 
@@ -655,7 +655,7 @@ static int print_command(void) {
            false          Success
 */
 
-static bool check_and_create_login_file(void) {
+static bool check_and_create_login_file() {
   DBUG_TRACE;
 
   MY_STAT stat_info;
@@ -1211,7 +1211,7 @@ static int decrypt_buffer(const char *cipher, int cipher_len, char plain[]) {
                           length written, otherwise.
 */
 
-static int add_header(void) {
+static int add_header() {
   DBUG_TRACE;
 
   /* Reserved for future use. */
@@ -1260,7 +1260,7 @@ bool generate_login_key() {
            0              Success
 */
 
-static int read_login_key(void) {
+static int read_login_key() {
   DBUG_TRACE;
 
   verbose_msg("Reading the login key.\n");
@@ -1315,7 +1315,7 @@ static void usage_command(int command) {
   my_print_variables(command_data[command].options);
 }
 
-static void usage_program(void) {
+static void usage_program() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2012"));
   puts("MySQL Configuration Utility.");

client/mysqladmin.cc

@@ -106,7 +106,7 @@ static uint ex_var_count, max_var_length, max_val_length;
 #include "client/include/caching_sha2_passwordopt-vars.h"
 #include "client/include/multi_factor_passwordopt-vars.h"
 
-static void usage(void);
+static void usage();
 extern "C" bool get_one_option(int optid, const struct my_option *opt,
                                char *argument);
 static bool sql_connect(MYSQL *mysql, uint wait);
@@ -1193,7 +1193,7 @@ static char **mask_password(int argc, char ***argv) {
   return (temp_argv);
 }
 
-static void usage(void) {
+static void usage() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2000"));
   puts("Administration program for the mysqld daemon.");

client/mysqldump.cc

@@ -834,14 +834,14 @@ static void check_io(FILE *file) {
   if (ferror(file) || errno == 5) die(EX_EOF, "Got errno %d on write", errno);
 }
 
-static void short_usage_sub(void) {
+static void short_usage_sub() {
   printf("Usage: %s [OPTIONS] database [tables]\n", my_progname);
   printf("OR     %s [OPTIONS] --databases [OPTIONS] DB1 [DB2 DB3...]\n",
          my_progname);
   printf("OR     %s [OPTIONS] --all-databases [OPTIONS]\n", my_progname);
 }
 
-static void usage(void) {
+static void usage() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2000"));
   puts("Dumping structure and contents of MySQL databases and tables.");
@@ -851,7 +851,7 @@ static void usage(void) {
   my_print_variables(my_long_options);
 } /* usage */
 
-static void short_usage(void) {
+static void short_usage() {
   short_usage_sub();
   printf("For more options, use %s --help\n", my_progname);
 }
@@ -5469,7 +5469,7 @@ static int do_stop_replica_sql(MYSQL *mysql_con) {
   return (0);
 }
 
-static int add_stop_replica(void) {
+static int add_stop_replica() {
   if (opt_comments)
     fprintf(md_result_file,
             "\n--\n-- stop replica statement to make a recovery dump\n--\n\n");
@@ -5478,7 +5478,7 @@ static int add_stop_replica(void) {
   return (0);
 }
 
-static int add_replica_statements(void) {
+static int add_replica_statements() {
   if (opt_comments)
     fprintf(md_result_file,
             "\n--\n-- start replica statement to make a recovery dump\n--\n\n");

client/mysqlimport.cc

@@ -246,7 +246,7 @@ static struct my_option my_long_options[] = {
 
 static const char *load_default_groups[] = {"mysqlimport", "client", nullptr};
 
-static void usage(void) {
+static void usage() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2000"));
   printf(

client/mysqlshow.cc

@@ -321,7 +321,7 @@ static struct my_option my_long_options[] = {
     {nullptr, 0, nullptr, nullptr, nullptr, nullptr, GET_NO_ARG, NO_ARG, 0, 0,
      0, nullptr, 0, nullptr}};
 
-static void usage(void) {
+static void usage() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2000"));
   puts(

client/mysqlslap.cc

@@ -280,12 +280,12 @@ uint parse_delimiter(const char *script, statement **stmt, char delm);
 int parse_option(const char *origin, option_string **stmt, char delm);
 static int drop_schema(MYSQL *mysql, const char *db);
 size_t get_random_string(char *buf);
-static statement *build_table_string(void);
-static statement *build_insert_string(void);
-static statement *build_update_string(void);
+static statement *build_table_string();
+static statement *build_insert_string();
+static statement *build_update_string();
 static statement *build_select_string(bool key);
 static int generate_primary_key_list(MYSQL *mysql, option_string *engine_stmt);
-static int drop_primary_key_list(void);
+static int drop_primary_key_list();
 static int create_schema(MYSQL *mysql, const char *db, statement *stmt,
                          option_string *engine_stmt);
 static void set_sql_mode(MYSQL *mysql);
@@ -720,7 +720,7 @@ static struct my_option my_long_options[] = {
     {nullptr, 0, nullptr, nullptr, nullptr, nullptr, GET_NO_ARG, NO_ARG, 0, 0,
      0, nullptr, 0, nullptr}};
 
-static void usage(void) {
+static void usage() {
   print_version();
   puts(ORACLE_WELCOME_COPYRIGHT_NOTICE("2005"));
   puts("Run a query multiple times against the server.\n");
@@ -791,7 +791,7 @@ size_t get_random_string(char *buf) {
   This function builds a create table query if the user opts to not supply
   a file or string containing a create table statement
 */
-static statement *build_table_string(void) {
+static statement *build_table_string() {
   char buf[HUGE_STRING_LENGTH];
   unsigned int col_count;
   statement *ptr;
@@ -897,7 +897,7 @@ static statement *build_table_string(void) {
   This function builds insert statements when the user opts to not supply
   an insert file or string containing insert data
 */
-static statement *build_update_string(void) {
+static statement *build_update_string() {
   char buf[HUGE_STRING_LENGTH];
   unsigned int col_count;
   statement *ptr;
@@ -961,7 +961,7 @@ static statement *build_update_string(void) {
   This function builds insert statements when the user opts to not supply
   an insert file or string containing insert data
 */
-static statement *build_insert_string(void) {
+static statement *build_insert_string() {
   char buf[HUGE_STRING_LENGTH];
   unsigned int col_count;
   statement *ptr;
@@ -1527,7 +1527,7 @@ static int generate_primary_key_list(MYSQL *mysql, option_string *engine_stmt) {
   return 0;
 }
 
-static int drop_primary_key_list(void) {
+static int drop_primary_key_list() {
   unsigned long long counter;
 
   if (primary_keys_number_of) {

client/mysqltest.cc

@@ -356,8 +356,8 @@ CHARSET_INFO *charset_info =
 */
 static char *timer_file = nullptr;
 static ulonglong timer_start;
-static void timer_output(void);
-static ulonglong timer_now(void);
+static void timer_output();
+static ulonglong timer_now();
 
 static ulong connection_retry_sleep = 100000; /* Microseconds */
 
@@ -3325,7 +3325,7 @@ static FILE *my_popen(DYNAMIC_STRING *ds_cmd, const char *mode,
   return popen(ds_cmd->str, mode);
 }
 
-static void init_builtin_echo(void) {
+static void init_builtin_echo() {
 #ifdef _WIN32
   size_t echo_length;
 
@@ -5127,7 +5127,7 @@ static void do_sync_with_master(struct st_command *command) {
   done on the local mysql server
 */
 
-static void ndb_wait_for_binlog_injector(void) {
+static void ndb_wait_for_binlog_injector() {
   MYSQL_RES *res;
   MYSQL_ROW row;
   MYSQL *mysql = &cur_con->mysql;
@@ -9641,7 +9641,7 @@ static void create_stacktrace_collector_event() {
 
 #else /* _WIN32 */
 
-static void init_signal_handling(void) {
+static void init_signal_handling() {
   struct sigaction sa;
   DBUG_TRACE;
 
@@ -10530,7 +10530,7 @@ int main(int argc, char **argv) {
   the time between executing the two commands.
 */
 
-void timer_output(void) {
+void timer_output() {
   if (timer_file) {
     char buf[32], *end;
     const ulonglong timer = timer_now() - timer_start;
@@ -10541,7 +10541,7 @@ void timer_output(void) {
   }
 }
 
-ulonglong timer_now(void) { return my_micro_time() / 1000; }
+ulonglong timer_now() { return my_micro_time() / 1000; }
 
 /*
   Get arguments for replace_columns. The syntax is:

components/libminchassis/dynamic_loader.cc

@@ -313,7 +313,7 @@ static PSI_rwlock_info all_dynamic_loader_rwlocks[] = {
     {&key_rwlock_LOCK_dynamic_loader, "LOCK_dynamic_loader", PSI_FLAG_SINGLETON,
      0, PSI_DOCUMENT_ME}};
 
-static void init_dynamic_loader_psi_keys(void) {
+static void init_dynamic_loader_psi_keys() {
   const char *category = "components";
   int count;
 

components/libminchassis/dynamic_loader_scheme_file.cc

@@ -52,7 +52,7 @@ static PSI_rwlock_info all_dynamic_loader_scheme_file_rwlocks[] = {
      "LOCK_dynamic_loader_scheme_file", PSI_FLAG_SINGLETON, 0,
      PSI_DOCUMENT_ME}};
 
-static void init_dynamic_loader_scheme_file_psi_keys(void) {
+static void init_dynamic_loader_scheme_file_psi_keys() {
   const char *category = "components";
   int count;
 

components/libminchassis/registry.cc

@@ -59,7 +59,7 @@ static PSI_rwlock_info all_registry_rwlocks[] = {
     {&::key_rwlock_LOCK_registry, "LOCK_registry", PSI_FLAG_SINGLETON, 0,
      PSI_DOCUMENT_ME}};
 
-static void init_registry_psi_keys(void) {
+static void init_registry_psi_keys() {
   const char *category = "components";
   int count;
 

components/logging/log_sink_syseventlog.cc

@@ -250,7 +250,7 @@ static void log_syslog_reopen() {
 /**
   Stop using syslog / EventLog. Call as late as possible.
 */
-void log_syslog_exit(void) {
+void log_syslog_exit() {
   log_syslog_close();
 
   // free ident.
@@ -473,7 +473,7 @@ static void sysvar_update_tag(MYSQL_THD thd [[maybe_unused]],
   @retval 0   success
   @retval -1  failure
 */
-static int sysvar_install_tag(void) {
+static int sysvar_install_tag() {
   char *var_value;
   char *new_value;
   size_t var_len = MAX_TAG_LEN;
@@ -607,7 +607,7 @@ static void sysvar_update_fac(MYSQL_THD thd [[maybe_unused]],
   @retval 0   success
   @retval -1  failure
 */
-static int sysvar_install_fac(void) {
+static int sysvar_install_fac() {
   char *var_value;
   char *new_value;
   size_t var_len = MAX_FAC_LEN;
@@ -695,7 +695,7 @@ static void sysvar_update_pid(MYSQL_THD thd [[maybe_unused]],
   @retval 0   success
   @retval -1  failure
 */
-static int sysvar_install_pid(void) {
+static int sysvar_install_pid() {
   char *var_value = nullptr;
   size_t var_len = 15;
   bool var_bool;

components/pfs_component/pfs_example_continent.cc

@@ -39,7 +39,7 @@ unsigned int continent_next_available_index = 0;
 
 Continent_record continent_records_array[CONTINENT_MAX_ROWS] = {{"", 0, false}};
 
-int continent_delete_all_rows(void) {
+int continent_delete_all_rows() {
   native_mutex_lock(&LOCK_continent_records_array);
   for (int i = 0; i < CONTINENT_MAX_ROWS; i++)
     continent_records_array[i].m_exist = false;
@@ -245,9 +245,7 @@ int write_rows_from_component(Continent_Table_Handle *handle) {
   return 0;
 }
 
-unsigned long long continent_get_row_count(void) {
-  return continent_rows_in_table;
-}
+unsigned long long continent_get_row_count() { return continent_rows_in_table; }
 
 void init_continent_share(PFS_engine_table_share_proxy *share) {
   /* Instantiate and initialize PFS_engine_table_share_proxy */