Fixup to backport of 'WL#15524 patch#2'

jdduncan · jdduncan · commit 59bdabd552bf · 2023-09-29T09:12:51.000-07:00
Replace "FIXME" comment with descriptive comment.

Change-Id: If55cf98f02e0448736f2295a1195223b19315ba1
diff --git a/storage/ndb/src/mgmapi/mgmapi.cpp b/storage/ndb/src/mgmapi/mgmapi.cpp
@@ -3643,7 +3643,8 @@ ndb_mgm_convert_to_transporter(NdbMgmHandle *handle)
     return {};
   }
 
-  // FIXME: Decide whether to keep this
+  // MySQL 8.0.33 through 8.2.x do not allow a TLS socket to be upgraded to
+  // a transporter connection. Beginning with MySQL 8.3 this is not an error.
   if ((*handle)->socket.has_tls())
   {
     SET_ERROR(*handle, NDB_MGM_CANNOT_CONVERT_TO_TRANSPORTER, "");

Original file line number	Diff line number	Diff line change
`@@ -3643,7 +3643,8 @@ ndb_mgm_convert_to_transporter(NdbMgmHandle *handle)`
`3643`	`3643`	`return {};`
`3644`	`3644`	`}`
`3645`	`3645`
`3646`		`- // FIXME: Decide whether to keep this`
	`3646`	`+ // MySQL 8.0.33 through 8.2.x do not allow a TLS socket to be upgraded to`
	`3647`	`+ // a transporter connection. Beginning with MySQL 8.3 this is not an error.`
`3647`	`3648`	`if ((*handle)->socket.has_tls())`
`3648`	`3649`	`{`
`3649`	`3650`	`SET_ERROR(*handle, NDB_MGM_CANNOT_CONVERT_TO_TRANSPORTER, "");`